[OpenSER-Devel] [ openser-Bugs-1737524 ] dialog: missing callback call for timeout on early dialogs

[SourceForge.net]

Bugs item #1737524, was opened at 2007-06-15 01:10
Message generated for change (Comment added) made by bogdan_iancu
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1737524&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: ver 1.2.x
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Ovidiu Sas (osas)
Assigned to: Bogdan (bogdan_iancu)
Summary: dialog: missing callback call for timeout on early dialogs

Initial Comment:
This bug is related to bug 1729550 - CANCEL does not update the dialog state:
http://sourceforge.net/tracker/index.php?func=detail&aid=1729550&group_id=139143&atid=743020

The scenario is the same. The dialog will transition from DLG_STATE_EARLY to DLG_STATE_DELETED on a callback from tm (TMCB_TRANS_DELETED) that will generate a DLG_EVENT_TDEL event.

In this particular case, the DLGCB_FAILED is not invoked.


Here's a simple patch that will fix this particular problem.  Maybe this is not the best approach (and it may not cover all other cases, but it is fixing this particular scenario):

# diff -Naurp dlg_handlers.c dlg_handlers.c.new 
--- dlg_handlers.c      2007-06-14 18:09:12.000000000 -0400
+++ dlg_handlers.c.new  2007-06-14 18:09:06.000000000 -0400
@@ -208,6 +208,13 @@ static void dlg_onreply(struct cell* t, 
                return;
        }
 
+       if ( event==DLG_EVENT_TDEL && new_state==DLG_STATE_DELETED &&
+               old_state==DLG_STATE_EARLY) {
+               DBG("DEBUG:dialog:dlg_onreply: dialog %p failed (transaction timeout)\n",
+                       dlg);
+               /* dialog setup not completed (timeout) */
+               run_dlg_callbacks( DLGCB_FAILED, dlg, rpl);
+       }
 
        return;
 }

----------------------------------------------------------------------

>Comment By: Bogdan (bogdan_iancu)
Date: 2007-07-05 10:06

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Hi Ovidiu,

do you have an example for a scenario where the transaction gets deleted
without any prior final reply?

Regards,
Bogdan

----------------------------------------------------------------------

Comment By: Bogdan (bogdan_iancu)
Date: 2007-07-03 16:21

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Hi Ovidiu,

I will take a look on this.

Regards,
bogdan

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1737524&group_id=139143