[Devel] Mediaproxy / function fix_contact

[Behr Jean-Luc]

Yes I agree.
But the function "fix_contact" is called to change the contact (IP address and port) that will be stored in the registrar.
This storing is processed in the function "save" of the module registrar.
And there the lump is not used ! 
The contact is taken from the message itself. In fact in the parsed structure.
So to modify the contact the function "fix_contact" modifies the parsed structure by using an allocated memory.
And I don't find the place where this memory is freed.

Thanks
Jean-Luc

-----Original Message-----
From: Bogdan-Andrei Iancu [mailto:bogdan at voice-system.ro]
Sent: jeudi 4 janvier 2007 18:07
To: Behr Jean-Luc
Cc: devel at openser.org
Subject: Re: [Devel] Mediaproxy / function fix_contact


Hi Jean-Luc,

I haven't look into this functions, but all the changes on a SIP message 
are done via lumps - you add a lump saying where and what you want to 
change. The lumps are kept in the sip_msg structure and freed along with it.

regards,
bogdan

Behr Jean-Luc wrote:

>Hi,
>
>In function fix_contact of module mediaproxy the IP:Port is replaced in the Contact field of the SIP message.
>This is done by replacing the pointer "uri.s" of the parsed structure in the message.
>The replacement is done thanks to an allocated memory (pkg_malloc).
>Usually "uri.s" points inside the message itself.
>I don't understand where this memory is freed.
>Any idea ?
>
>Thanks,
>Jean-Luc
>
>
>_______________________________________________
>Devel mailing list
>Devel at openser.org
>http://openser.org/cgi-bin/mailman/listinfo/devel
>
>  
>