[Devel] [ openser-Bugs-1669308 ] lcr: lcr broken in dbtex mode

[SourceForge.net]

Bugs item #1669308, was opened at 2007-02-26 12:29
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1669308&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: ver devel
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Ovidiu Sas (osas)
Assigned to: Nobody/Anonymous (nobody)
Summary: lcr: lcr broken in dbtex mode

Initial Comment:
I think this is related to the fact that dbtext doesn't have a DB_STRING attribute.

Here's a small patch that will fix the issue:
$ diff -Naurp openser-r1699/modules/lcr/lcr_mod.c openser/modules/lcr/lcr_mod.c
--- openser-r1699/modules/lcr/lcr_mod.c	2007-02-26 10:53:18.000000000 -0500
+++ openser/modules/lcr/lcr_mod.c	2007-02-26 12:18:42.000000000 -0500
@@ -726,8 +726,7 @@ int reload_gws ( void )
     
     for (i = 0; i < RES_ROW_N(res); i++) {
 	row = RES_ROWS(res) + i;
-	if (!((VAL_TYPE(ROW_VALUES(row)) == DB_STRING) &&
-	      !VAL_NULL(ROW_VALUES(row)) &&
+	if (!(!VAL_NULL(ROW_VALUES(row)) &&
 	      inet_aton((char *)VAL_STRING(ROW_VALUES(row)), &ip_addr) != 0)) {
 	    LOG(L_ERR, "reload_gws(): Invalid IP address of GW\n");
 	    lcr_dbf.free_result(dbh, res);


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1669308&group_id=139143