[Devel] [ openser-Bugs-1667286 ] usrloc: get_all_ucontacts doesn't obey branch-flags

[SourceForge.net]

Bugs item #1667286, was opened at 2007-02-23 19:34
Message generated for change (Comment added) made by bogdan_iancu
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1667286&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
>Category: modules
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Marcus Hunger (marcushunger)
>Assigned to: Bogdan (bogdan_iancu)
Summary: usrloc: get_all_ucontacts doesn't obey branch-flags

Initial Comment:
Hi,
get_all_ucontacts ignores the cflags when collecting contacts. This breaks at least ping_nated_only. The attached patch fixes this in get_all_mem_ucontacts but I am not sure how to handle flags in get_all_db_ucontacts.

Marcus

----------------------------------------------------------------------

>Comment By: Bogdan (bogdan_iancu)
Date: 2007-02-24 21:28

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Hi Marcus,

thanks for the report - good catch!! I applied your patch and also fixed
the get_all_db_ucontacts(). To complete the fix, I had to move the flag for
marking SIP pinging from message flag to branch flag (to be consistent with
the nat flag, also branch flag). This also forced to move the SIP ping flag
from the registrar to nathelper module. You can use any branch flag to mark
the contact for SIP ping as all branch flags are saved and restored by
usrloc. Nathelper module just needs to know the flag index to identify the
contacts. 

thanks and regards,
Bogdan

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1667286&group_id=139143