[Devel] [ openser-Bugs-1658796 ] debian build prcoess should stop on build error

[SourceForge.net]

Bugs item #1658796, was opened at 2007-02-13 12:31
Message generated for change (Comment added) made by bogdan_iancu
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1658796&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: packaging
Group: ver devel
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Klaus Darilion (klaus_darilion)
>Assigned to: Bogdan (bogdan_iancu)
Summary: debian build prcoess should stop on build error

Initial Comment:
When there is build error during "make deb"  (e.g. a module fails to compile) the debian packaging process still goes on and in the end you get .deb packages where the library is missing (tested with packaging/debian-sarge)

IMO, if there is a build error, the whole build process should stop. Otherwise you will end up with incomplete debian packages.



----------------------------------------------------------------------

>Comment By: Bogdan (bogdan_iancu)
Date: 2007-02-21 14:30

Message:
Logged In: YES 
user_id=1275325
Originator: NO

The patch from Henning (with some extensions) was applied on CVS.

Thanks,
Bogdan

----------------------------------------------------------------------

Comment By: Klaus Darilion (klaus_darilion)
Date: 2007-02-13 15:31

Message:
Logged In: YES 
user_id=1318360
Originator: YES

patch suggested by Henning Westerholt:

We have the same problem here. We're using the following patch for the 
Makefile:

Best regards,

Henning


Index: Makefile
===================================================================
RCS file: /cvsroot/openser/sip-server/Makefile,v
retrieving revision 1.40
diff -d -u -H -r1.40 Makefile
--- Makefile    12 Feb 2007 18:17:04 -0000      1.40
+++ Makefile    13 Feb 2007 11:34:20 -0000
@@ -152,7 +152,8 @@

 .PHONY: modules
 modules:
-       - at for r in $(modules) "" ; do \
+       @set -e; \
+       for r in $(modules) "" ; do \
                if [ -n "$$r" ]; then \
                        echo  "" ; \
                        echo  "" ; \

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1658796&group_id=139143