[Devel] [ openser-Bugs-1637284 ] NOTIFY not sent on refresh as per RFC3265/3.1.6.2

[SourceForge.net]

Bugs item #1637284, was opened at 2007-01-17 01:13
Message generated for change (Comment added) made by anca_vamanu
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1637284&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: ver devel
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Kobi Eshun (ekobi)
>Assigned to: anca (anca_vamanu)
Summary: NOTIFY not sent on refresh as per RFC3265/3.1.6.2

Initial Comment:
Hi,

It appears that the Notifier implemented by the Presence module does not "send a NOTIFY message immediately upon successfully accepting a or refreshing a subscription," as defined in RFC 3265/3.1.6.2.

I'll take a look to see if I can figure it out, but I imagine it will be trivial to locate/fix for you. Cheers,
--
kobi

----------------------------------------------------------------------

>Comment By: anca (anca_vamanu)
Date: 2007-02-13 14:05

Message:
Logged In: YES 
user_id=1614776
Originator: NO

Hello,

The error is now fixed on the latest version on cvs. 
Thank you for reporting the error and for the patch.I haven't used it
eventualy because some other changes
were more apropriate.

Best regards, 

Anca Vamanu

----------------------------------------------------------------------

Comment By: Aron Rosenberg (amr42)
Date: 2007-02-12 18:14

Message:
Logged In: YES 
user_id=43318
Originator: NO

Patch included in comments for this bug since SourceForge won't let
non-submitter's attach files to bug reports. Patch also submitted in
patches section of tracker.

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2007-02-06 01:53

Message:
Logged In: NO 

This bug causes several SIP stacks to break since they will not issue
reSUBSCRIBE's if this NOTIFY is not sent. Resiprocate is one of these
stacks.

----------------------------------------------------------------------

Comment By: Aron Rosenberg (amr42)
Date: 2007-02-05 22:35

Message:
Logged In: YES 
user_id=43318
Originator: NO

This bug causes several SIP stacks to break since they will not issue
reSUBSCRIBE's if this NOTIFY is not sent. Resiprocate is one of these
stacks.

----------------------------------------------------------------------

Comment By: Aron Rosenberg (amr42)
Date: 2007-01-17 02:05

Message:
Logged In: YES 
user_id=43318
Originator: NO

The following patch should fix the issue
diff -u -p -r1.10 subscribe.c
--- modules/presence/subscribe.c	14 Dec 2006 11:12:42 -0000	1.10
+++ modules/presence/subscribe.c	17 Jan 2007 01:43:44 -0000
@@ -369,8 +369,16 @@ int update_subscribtion(struct sip_msg* 
 				goto error;
 			}
 		}	
-			
+		if(subs->reason.len!= 100)
+		{
+			subs->reason.len = 0;
+			if(notify(subs, NULL, NULL)< 0)
+			{
+				LOG(L_ERR, "PRESENCE:update_subscribtion: Could not send"
+					" notify for presence\n");
+			}	
+		}
 	}
 	else
 	{


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1637284&group_id=139143