[Devel] append_branch

[Bogdan-Andrei Iancu]

Hi Klaus,

if in all these places is used do_action() to append the branch, yes, 
the new code will be used. But have in mind that there will be no change 
as all the module use append_branch() to add a new branch with a new uri 
and not to copy the branch[0] in a new branch - and for adding a new 
branch with uri, nothing was changed.

regards,
bogdan

Klaus Darilion wrote:
> Hi Bogdan!
>
> Does this only change the behaviour of the script function or does it also
> change the behaviour of the implict append_branch used by e.g. lcr's
> next_gw or dispatcher's ds_next_dst?
>
> regards
> klaus
>
>
> On Wed, February 7, 2007 19:44, Bogdan-Andrei Iancu said:
>   
>> Hi Klaus,
>>
>> I made a fix for the append_branch function - can you run some tests
>> also to double check the outcome ?
>>
>> thanks and regards,
>> bogdan
>>
>> Bogdan-Andrei Iancu wrote:
>>     
>>>>> if we expand a bit the idea, it should be a different logic behind
>>>>> append_branch(); and append_branch(URI); :
>>>>>
>>>>>           
>>>> btw: append_branch(URI) it not documented on the core wiki.
>>>>
>>>>
>>>>         
>>>>>     append_branch() - appends current branch[0] (RURI) as a new
>>>>> branch;
>>>>> the request must be reset after;
>>>>>     append_branch(URI) - appends a new URI as a new branch; this new
>>>>> URI
>>>>> should not inherit and reset anything from branch[0].
>>>>>
>>>>>           
>>>> I agree. Will you apply this logic to 1.2?
>>>>
>>>>         
>>> for me, the current logic (or lack of logic) is buggy, so I will open
>>> a bug report about append_branch logic.
>>>
>>> regards,
>>> bogdan
>>>
>>> _______________________________________________
>>> Devel mailing list
>>> Devel at openser.org
>>> http://openser.org/cgi-bin/mailman/listinfo/devel
>>>
>>>       
>>     
>
>
>
>