[Devel] [ openser-Bugs-1653584 ] lcr broken on big endian platforms

[Ovidiu Sas]

Hi Bogdan and Juha,

I have no problem with that.  In the patch that I propose I went the
minimal change path, but I'm more than happy with a more general
solution.
If it's a string, it will remove the IP only restriction that we have
today (i.e. we can have FQDNs in the lcr routing table).

Also, I would suggest printing the name of the gw in the output of the
fifo lcr_dump command.  I helps a little bit in identifying the GW :-)


Regards,
Ovidiu Sas

On 2/8/07, Bogdan-Andrei Iancu <bogdan at voice-system.ro> wrote:
> Hi,
>
> as the fix implies anyhow a change, I agree with Juha and it should be
> switched to IP as string.
>
> regards,
> bogdan
>
> Juha Heinanen wrote:
> > ovidiu,
> >
> > are you proposing to change the way ip address is encoded in gw table's
> > ip_address column?
> >
> > if so, i.e., if people need to make change to the values in ip_address
> > column, then a better solution would be to store ip address as a doted
> > string.  it was stored as an encoded unsigned int for performance
> > reasons in the old non-caching implementation of load_gws function.
> >
> > now when there is only caching implementation of load_gws, there is no
> > reason anymore to keep the ip addresses binary encoded in the
> > database.
> >
> > -- juha
> >
> > _______________________________________________
> > Devel mailing list
> > Devel at openser.org
> > http://openser.org/cgi-bin/mailman/listinfo/devel
> >
> >
>
>
> _______________________________________________
> Devel mailing list
> Devel at openser.org
> http://openser.org/cgi-bin/mailman/listinfo/devel
>