[OpenSER-Devel] SF.net SVN: openser: [3429] trunk

[Dan Pascu]

On Wednesday 19 December 2007, Bogdan-Andrei Iancu wrote:
> Hi Henning,
>
> wouldn't be better to have the prototype exactly with the 6 parameters
> (instead of "int (*cmd_function)(struct sip_msg*, ...);" ? Just to be
> sincronized with the way the functions are called from the action.c
> (with 6 params). Otherwise I do not see any difference.

I agree. It makes no sense to declare it as receiving a variable number of 
args when in fact it receives a fixed number or args. The idea with using 
the ellipsis is to use it in a module function prototype if you plan to 
implement multiple function signatures using a single function and 
varargs. Otherwise it's not needed anywhere.

>
> Just an idea :)
>
> Regards,
> Bogdan
>
> Henning Westerholt wrote:
> > Revision: 3429
> >          
> > http://openser.svn.sourceforge.net/openser/?rev=3429&view=rev Author:
> >   henningw
> > Date:     2007-12-18 09:35:40 -0800 (Tue, 18 Dec 2007)
> >
> > Log Message:
> > -----------
> > - More flexible module function interface
> > - Its now possible to use up to 6 parameter in the config script for
> > module functions - This is configurable with a #define
> > - Every module function exports that lacks a cast to (cmd_function)
> > produces a warning now, this needs to be fixed
> > - Credits for implementation and tests goes to Hardy Kahl, hardy dot
> > kahl at 1und1 dot de
> >
> > Modified Paths:
> > --------------
> >     trunk/action.c
> >     trunk/cfg.y
> >     trunk/route.c
> >     trunk/route_struct.h
> >     trunk/sr_module.h
> >
> >
> > This was sent by the SourceForge.net collaborative development
> > platform, the world's largest Open Source development site.
> >
> > _______________________________________________
> > Devel mailing list
> > Devel at lists.openser.org
> > http://lists.openser.org/cgi-bin/mailman/listinfo/devel
>
> _______________________________________________
> Devel mailing list
> Devel at lists.openser.org
> http://lists.openser.org/cgi-bin/mailman/listinfo/devel



-- 
Dan