[Devel] SIP Identity support

[Alexander Christ]

Hello Henning,

thank you for the review of the code. I use gcc 3.3.5 and libssl 0.9.7. The 
function prototypes of "ASN1_item_d2i" and "meth->d2i" have changed in libssl 
0.9.8. The warnings due to signedness only appear with gcc versions > 3.3.5.

I have fixed the code. The attachment contains patches for "identity.c" and 
"identity.h".

Regards
Alexander

On Friday 30 March 2007 10:49, Henning Westerholt wrote:
> On Thursday 22 March 2007 20:28, Alexander Christ wrote:
> > Hello Klaus!
> >
> > I know that there is the auth_identity module in ser. But I do not know
> > much more about it. I have developed my module completely independent of
> > this one.
> >
> > I build the identity header using the original received message.
> >
> > I am going to port it to devel version, write a (short) English
> > documentation and upload it on the "patches" tracker within the next few
> > days.
>
> Hello Alexander,
>
> thank you for uploading the module to the tracker.
> I did a short review of the code, and noticed some minor issues.
>
> * the header file lacks the GPL copyright and the #ifndef double include
> guards, this is some kind of standard in this project.
>
> * I get some warnings during compiling due to signess differences and
> pointer type incompatiblity. These should be fixed.
>
> Compiling identity.c
> gcc -fPIC -DPIC -g -O9 -funroll-loops -Wcast-align -Wall
> -minline-all-stringops -falign-loops -ftree-vectorize -mtune=athlon64   
> -DNAME='"openser"' -DVERSION=' .. c -o identity.o
> identity.c: In function ‘getDate’:
> identity.c:381: warning: implicit declaration of function ‘strptime’
> identity.c: In function ‘addDate’:
> identity.c:442: warning: dereferencing type-punned pointer will break
> strict-aliasing rules
> identity.c: In function ‘addContentLength’:
> identity.c:543: warning: dereferencing type-punned pointer will break
> strict-aliasing rules
> identity.c: In function ‘addIdentity’:
> identity.c:758: warning: pointer targets in passing argument 2
> of ‘EVP_SignFinal’ differ in signedness
> identity.c:758: warning: pointer targets in passing argument 3
> of ‘EVP_SignFinal’ differ in signedness
> identity.c:777: warning: pointer targets in passing argument 1
> of ‘EVP_EncodeBlock’ differ in signedness
> identity.c:777: warning: pointer targets in passing argument 2
> of ‘EVP_EncodeBlock’ differ in signedness
> identity.c:795: warning: dereferencing type-punned pointer will break
> strict-aliasing rules
> identity.c: In function ‘addIdentityInfo’:
> identity.c:832: warning: dereferencing type-punned pointer will break
> strict-aliasing rules
> identity.c: In function ‘checkAuthority’:
> identity.c:1118: warning: passing argument 2 of ‘ASN1_item_d2i’ from
> incompatible pointer type
> identity.c:1122: warning: passing argument 2 of ‘meth->d2i’ from
> incompatible pointer type
> identity.c: In function ‘checkSign’:
> identity.c:1210: warning: pointer targets in passing argument 1
> of ‘EVP_DecodeBlock’ differ in signedness
> identity.c:1210: warning: pointer targets in passing argument 2
> of ‘EVP_DecodeBlock’ differ in signedness
> identity.c:1232: warning: pointer targets in passing argument 2
> of ‘EVP_VerifyFinal’ differ in signedness
> identity.c: In function ‘parseX509Date’:
> identity.c:1334: warning: pointer targets in assignment differ in
> signedness identity.c:1358: warning: pointer targets in assignment differ
> in signedness
>
> Cheers,
>
> Henning
-------------- next part --------------
A non-text attachment was scrubbed...
Name: identity.c.patch
Type: text/x-diff
Size: 1925 bytes
Desc: not available
Url : http://openser.org/pipermail/devel/attachments/20070406/6a16c3ef/identity.c.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: identity.h.patch
Type: text/x-diff
Size: 1949 bytes
Desc: not available
Url : http://openser.org/pipermail/devel/attachments/20070406/6a16c3ef/identity.h.bin