[Devel] Dialog module updating timeout value on PRACK

Ron Winacott ronw at somanetworks.com
Thu Oct 5 19:58:15 CEST 2006


Bogdan,
	With changes I am making to the SST module, I noticed that the dialog module 
is updating the timeout value on a PRACK in the dlg_onroute() callback. You 
ignore ACKs but you do not ignore PRACKs.  The fix is a simple expansion of 
the existing if (method == ACK) to if (method == ACK or PRACK). Do you want 
me to push the change to CVS, or do you want to apply it?

I have included the patch text in this email just in case you want to do 
it. :-)

Thanks,
	ronw (karwin)
-- 
Ron Winacott - SOMA Networks, Inc.

--- dlg_handlers.c.~1.5.~	2006-07-06 06:13:36.000000000 -0400
+++ dlg_handlers.c	2006-10-02 08:59:32.000000000 -0400
@@ -379,7 +379,8 @@
 		run_dlg_callbacks( DLGCB_REQ_WITHIN, dlg, req);
 	}
 
-	if (req->first_line.u.request.method_value!=METHOD_ACK) {
+	if (req->first_line.u.request.method_value!=METHOD_ACK && 
+			req->first_line.u.request.method_value!=METHOD_PRACK) {
 		dlg->lifetime = get_dlg_timeout(req);
 		update_dlg_timer( &dlg->tl, dlg->lifetime );
 	}



More information about the Devel mailing list