[Devel] acc diff

Juha Heinanen jh at tutpro.com
Tue Oct 3 15:39:25 CEST 2006


Dan Pascu writes:

 > That's exactly my point. I do NOT want to do all this avp testing and 
 > manipulation in the script. This was previously done by openser.
 > What is the point of replicating the same logic in 99% of the openser.cfg 
 > scripts out there?

because this may work for you now, but perhaps not anymore in near
future.  what if request comes from another operator, p-a header has
been removed and replaced by p-a-i header as specified by rfc 3325 and
from uri is anonymous?  this proves that it is plain stupid to hardwire
caller username algorithm in the code.  i don't understand what you have
against 4 lines of openser.cfg code.

 > I would rather want to see a default for this (since almost everyone will 
 > use it) and a way to overwrite it.

overwriting does not work, because i don't want to calculate any
UserName for some requests.

if people feel sick about 4 lines of openser.cfg programming, then i
don't see any other option than having a module parameter that tells if
caller username should be included or not.  and if included, it should
be included for every backend.

-- juha



More information about the Devel mailing list