[Devel] [ openser-Bugs-1579127 ] permanent contact expires in DB_ONLY mode

[SourceForge.net]

Bugs item #1579127, was opened at 2006-10-17 20:01
Message generated for change (Comment added) made by bogdan_iancu
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1579127&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: ver 1.1.x
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Andreas Granig (agranig)
Assigned to: Bogdan (bogdan_iancu)
Summary: permanent contact expires in DB_ONLY mode

Initial Comment:
I've some registrars and proxies using db_mode 3 on
OpenSER 1.1.0. When I try to add a permanent contact
into the location table using openserctl, the
"permanent"-flag (128) is set, but the contact is
removed upon hit of next timer.

I quickly checked the source code, but couldn't find
any timer handling for mode DB_ONLY.

----------------------------------------------------------------------

>Comment By: Bogdan (bogdan_iancu)
Date: 2006-11-21 20:23

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Hi Andreas,

I made an extensive fix on the CVS head - could you please tests to see if
everything is ok?

thanks and regards,
bogdan

----------------------------------------------------------------------

Comment By: Bogdan (bogdan_iancu)
Date: 2006-10-27 16:28

Message:
Logged In: YES 
user_id=1275325

The bug was found - in DB_ONLY, the expired contacts are
deleted from the timer process based on the "expires"
column, but with no checking on the flags to see if it is a
permanent contact.

Solution:
1) the query should look at "flags" column to see if it is a
permanent contact or not. Not sure if it possible because of
the SQL syntax.....
2) the "expires" column should reflect the idea of a
"permanent" contact.

regards,
bogdan

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1579127&group_id=139143