[Devel] [ openser-Bugs-1474155 ] ACK building for negative replies in local transactions

[SourceForge.net]

Bugs item #1474155, was opened at 2006-04-21 14:38
Message generated for change (Comment added) made by bogdan_iancu
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1474155&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: ver 1.0.x
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Elias Baixas (eliasbaixas)
>Assigned to: Bogdan (bogdan_iancu)
Summary: ACK building for negative replies in local transactions

Initial Comment:
(Transaction Module, local UAC transactions)

When the ACK is built for a response to a local UAC
transaction, it is build using build_dlg_ack().

the ACK's request-URI is created from the Route-Set (if
it exists) or from Contact (if no route-set), although
section 17.1.1.3 (construction of the ACK request) in
3261 says that the ACK must have the same
request-URI,From and Call-ID headers as the original
INVITE. So the request-URI should be taken from the
transaction buffer (t->uac[0].request).

I've found that changing build_dlg_ack() with:

process_routeset(rpl,&contact,&list,&ruri,&next_hop)
to  
process_routeset(rpl,&Trans->uac[0].uri,&list,&ruri,&next_hop)

and then

if((contact.s != ruri.s)||(contact.len!= ruri.len)){
to
if((Trans->uac[0].uri.s!=ruri.s)||(Trans->uac[0].uri.len
!=ruri.len)){

fixes this behavior.

----------------------------------------------------------------------

>Comment By: Bogdan (bogdan_iancu)
Date: 2006-05-29 19:57

Message:
Logged In: YES 
user_id=1275325

Elias,

the fix was slightly different - it was committed on CVS.
Please update and see if works properly for both 2xx and
negative replies.
If there are still some problems, please re-open the bug report.

Thanks and regards,
Bogdan

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1474155&group_id=139143