[Devel] Last changes before CVS freez

[Bogdan-Andrei Iancu]

Juha Heinanen wrote:

>Bogdan-Andrei Iancu writes:
>
> > that's right - acc_rad_missed() will generate one record and a second 
> > one will be by acc_rad_reply(). But as in your scenario it's about a 
> > transaction with a negative response (408), the acc_rad_reply() should 
> > generate the record *only* if the failed_transaction_flag is set.
>
>i don't get it.  in acc_onreply (which is called upon
>TMCB_RESPONSE_OUT), there is this if statement:
>
>	if (is_rad_acc_on(req))
>		acc_rad_reply(t, req, reply, code);
>
>since nobody has reseted radius_flag acc_rad_reply will get called and
>if you check acc_rad_reply, it will unconditionally call
>acc_rad_request:
>  
>
acc_onreply() function, before testing per-backend flags, tests if the 
reply is suitable for accounting. See line 725:
    if (!should_acc_reply(req, code)) return;

this function checks the failed_transaction_flag if a negative reply is 
processed.

regards,
bogdan