[Devel] fix_nated_sdp(flags, IP) does not update the IP inside SDP

[Ovidiu Sas]

Hi Bogdan,

Thx for the clarification :)
The web doc should be updated too:
http://www.openser.org/docs/modules/1.1.x/nathelper.html

And maybe the flag section should be updated too:
  0x02 - rewrite media IP address (c=) with source address of the
message or the provided IP address (the provide IP address take
precedence over the source address).
  0x08 - rewrite IP from origin description (o=) with source address
of the message or the provided IP address (the provide IP address take
precedence over the source address).


-ovi

On 6/7/06, Bogdan-Andrei Iancu <bogdan at voice-system.ro> wrote:
> Hi Ovidiu,
>
> indeed there was a bogus ERROR message in extract_mediaip() - I removed it.
>
> regarding the fix_nated_sdp("1", "10.111.5.15 <http://10.111.5.15>");
> call, the problem is that you do not set the flag for replacing the IP
> in c= or o= line (02 or 08 flags). The flag presence is mandatory since
> the IP can be pushed in different locations into the SDP - and via flags
> you control where to be pushed. I made a note in the docs in order to
> avoid this kind of misunderstanding for the feature.
>
> regards,
> bogdan