[Devel] [ openser-Patches-1435346 ] parser changes for SIP Session Timers (SST) headers

[SourceForge.net]

Patches item #1435346, was opened at 2006-02-20 19:40
Message generated for change (Settings changed) made by bogdan_iancu
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743022&aid=1435346&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: core
Group: ver devel
>Status: Closed
>Resolution: Accepted
Priority: 5
Submitted By: D. H. (dchsueh)
Assigned to: Bogdan (bogdan_iancu)
Summary: parser changes for SIP Session Timers (SST) headers

Initial Comment:
code to parse the Session-Expires and Min-SE headers
RFC4028 specifies SST


----------------------------------------------------------------------

Comment By: D. H. (dchsueh)
Date: 2006-02-28 19:52

Message:
Logged In: YES 
user_id=1452070

updated patch and new source files attached
-- Daniel Hsueh <dhsueh at somanetworks.com>

----------------------------------------------------------------------

Comment By: Bogdan (bogdan_iancu)
Date: 2006-02-28 11:57

Message:
Logged In: YES 
user_id=1275325

Daniel,
thanks for the patch - on a first look everythink looks ok,
but there are some small issues with the conding. Do not get
me wrong but we try to keep some consistency across all the
code. So, please:
1) place variable declaration only at the begining of the
functions
2) avoid lines longer than 80 chars (breaks them o several
lines) - coding via standart UNIX terminals must be as
easier as in X apps.
Please remake the patch and I will commit it on CVS

thanks,
bogdan

----------------------------------------------------------------------

Comment By: D. H. (dchsueh)
Date: 2006-02-27 16:39

Message:
Logged In: YES 
user_id=1452070

this patch is from
Daniel Hsueh <dhsueh at somanetworks.com>


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743022&aid=1435346&group_id=139143