[Devel] Improving force_rtp_proxy

[Marc Haisenko]

On Tuesday 21 February 2006 19:24, Bogdan-Andrei Iancu wrote:
> Hi Marc,
>
> indeed, the code limits the force_rtp_proxy() usage to INVITEs when
> comes to requests. There are 2 solutions here:
>     1) remove the method limitation - anyhow you decide from script for
> what request you call or not the function
>     2) along with INVITE, add ACK.
>
> my personal option is 1) .
>
> In both cases, the change is trivial :).
>
> regards,
> bogdan

Hmmm, it doesn't seem to be /that/ trivial. The problem is that I need to 
decide what to do on an "OK": I have no idea whether the corresponding INVITE 
had SDP or not. So my current solution is to handle the OK as always, but 
when the RTP proxy communication result shows that no entry is present I 
rerun the whole force_rtp_proxy2_f function where I set an additional 
argument so the "OK" gets handled like an "INVITE" (I renamed the original 
force_rtp_proxy2_f and put a wrapper in its place). ACKs are handled like 
INVITES... but it just occurs to me that they should be handled like OKs 
instead.

I hope you understand what I mean :-)

Now what I don't like in this approach is that one additional RTP proxy 
message exchange occurs... but it /seems/ like it works and the code changes 
are trivial. I've attached my patch so you can actually see what I mean, but 
I hope you have an idea to solve this problem in a more elegant way :-)

-- 
Marc Haisenko
Comdasys AG

Rüdesheimer Straße 7
D-80686 München
Tel:   +49 (0)89 - 548 43 33 0
Fax:   +49 (0)89 - 548 43 33 29
e-mail: haisenko at comdasys.com
http://www.comdasys.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openser-akira-force_rtp_proxy.patch
Type: text/x-diff
Size: 1609 bytes
Desc: not available
Url : http://openser.org/pipermail/devel/attachments/20060222/dba68294/openser-akira-force_rtp_proxy.bin