[Devel] CVS commitlog: sip-server items.c items.h

Dan Pascu dan at ag-projects.com
Tue Dec 26 16:53:19 CET 2006


On Tuesday 26 December 2006 14:39, Juha Heinanen wrote:
> Dan Pascu writes:
>  > How about cases where the value is to be embedded in some avp using
>  > avp_printf or logged with xlog?
>
> privacy value is bitmap that does not tell much in xlog.  for logging
> it is better to pseudo variable that contains body of header.

Now I'm confused. Do you say that there is still a pseudo variable that 
coresponds to the Privacy header (other than $hdr(Privacy))?

>
>  > I think every header element should have a corresponding pv, even if
>  > it is rarely used, or tests for that header exist in the textops
>  > module, exactly for the cases like those mentioned above.
>
> if there is some other use case that logging let me know and i'll put
> it back.

I'm do not have so much use cases in mind, as I'm thinking of the fact 
that the pseudo variables should have symmetry and completeness (i.e. 
they should be able to pinpoint every element of the message as long as 
it is parsed). This is not something you cannot work around (for example 
by using $hdr(Privacy)), but it would be nice to have a $xx shortcut for 
every header element that is parsed IMO.

-- 
Dan



More information about the Devel mailing list