[Devel] Re: Using drop() in Branch_Route seems to break subsequent branches (bug?)

[Tavis P]

I've done tests with the latest code and i'm still seeing the problem,
could this be the same old issue with cvs not getting updated?

Do you have a more recent copy i could look at?



Bogdan-Andrei Iancu wrote:
> Hi Tavis,
>
> have you had the chance to test the fix on the devel branch - I was
> waiting for some positive feedback before backporting this fix on the
> stable tree.
>
> regards,
> bogdan
>
> Tavis P wrote:
>
>> Will this fix be backported before the end of the month?
>>
>> I'm rolling out a new system and the drop() functionality is critical
>>
>> Also, the exit() function seems to exhibit the same problem that the
>> drop() function does in branch_route()
>>
>> thanks
>> tavis
>>
>> Tavis P wrote:
>>  
>>
>>> thanks
>>>
>>> Bogdan-Andrei Iancu wrote:
>>>  
>>>   
>>>> Tavis,
>>>>
>>>> the fix is available on CVS head. If everything goes well (read: no
>>>> side effects), I will backport the fix on the 1.0.1 version
>>>>
>>>> regards,
>>>> bogdan
>>>>
>>>> Bogdan-Andrei Iancu wrote:
>>>>
>>>>        
>>>>> Hi Tavis,
>>>>>
>>>>> thanks to your script sample we were able to reproduce and identify
>>>>> the bug. right now we  are working on a fix.
>>>>>
>>>>> thanks for report and regards,
>>>>> bogdan
>>>>>
>>>>> Tavis P wrote:
>>>>>
>>>>>            
>>>>>> I forgot to mention that i'm using a copy of OpenSER 1.0.0 (1.0.1?)
>>>>>> checked out of CVS around Tuesday Apr  4 23:05:56 UTC 2006
>>>>>>
>>>>>> Tavis P wrote:
>>>>>>
>>>>>>
>>>>>>                
>>>>>>> According to the core docs, inside of a OnReply_Route or Branch
>>>>>>> Route,
>>>>>>> the drop() function needs to be used in place of exit() if you
>>>>>>> want to
>>>>>>> discard the message
>>>>>>>
>>>>>>> I think i've encountered a bug where all subsequent branches
>>>>>>> that come
>>>>>>> after a branch that was "drop()"'d are summarily ignored before
>>>>>>> with
>>>>>>> only the first statement being executed inside the Branch_Route
>>>>>>>
>>>>>>> I've attached a really simple test script, you will need to
>>>>>>> change the
>>>>>>> "port=15061" line
>>>>>>>
>>>>>>> Sending an invite through this script will be branched 4 ways,
>>>>>>> however
>>>>>>> at the second branch i execute drop() and all subsequent
>>>>>>> branches are
>>>>>>> simply left as it (they do not process any of the logic in the
>>>>>>> branch_route except for the first line)
>>>>>>>
>>>>>>>
>>>>>>> thanks!
>>>>>>>
>>>>>>> tavis
>>>>>>>
>>>>>>>
>>>>>>>                    
>>>>> _______________________________________________
>>>>> Devel mailing list
>>>>> Devel at openser.org
>>>>> http://openser.org/cgi-bin/mailman/listinfo/devel
>>>>>
>>>>>            
>>>>        
>>> _______________________________________________
>>> Devel mailing list
>>> Devel at openser.org
>>> http://openser.org/cgi-bin/mailman/listinfo/devel
>>>
>>>
>>>  
>>>   
>>
>>  
>>
>
>