[Devel] CVS commitlog: sip-server/modules/postgres dbase.c

[Klaus Darilion]

The problem was:


BEGIN
INSERT into acc ... failed-->return without commit

next time this thread wanted to account a message

BEGIN (produces an error as the transcation is still alive)
re-connect
BEGIN
INSERT
COMMIT


Now:
BEGIN
INSERT into acc ... failed
ROLLBACK

transcation finished, ready for new transcations

regards
klaus

Michael Ulitskiy wrote:

> On Tuesday 13 September 2005 02:05 pm, Klaus Darilion wrote:
> 
>>User: klaus_darilion
>>Date: 2005/09/13 11:05:03 PDT
>>
>>  OpenSER CVS - Commit Details
>>
>>  Modified files:
>>    modules/postgres     dbase.c 
>>  Commit Log:
>>  - adding transaction rollback for failed queries (postgres module encapsulates every query into transaction. If the query failed, the transcation was not finished, thus a new database connection was created on the next query)
> 
> 
> Hm... do you really reconnect to db in this case? why not just issue rollback?
>    
> 
>>  Revision  Changes    Path
>>  1.4       +45 -15    sip-server/modules/postgres/dbase.c
>>   [ http://cvs.sourceforge.net/viewcvs.py/openser/sip-server/modules/postgres/dbase.c?r1=1.3&r2=1.4 ]
>>
>>_______________________________________________
>>Devel mailing list
>>Devel at openser.org
>>http://openser.org/cgi-bin/mailman/listinfo/devel
>>
> 
> 
> _______________________________________________
> Devel mailing list
> Devel at openser.org
> http://openser.org/cgi-bin/mailman/listinfo/devel
> 
>