[Devel] ucontact flags

Juha Heinanen jh at tutpro.com
Tue Nov 15 14:06:40 CET 2005


Daniel-Constantin Mierla writes:

 > I analyzed a bit in the last days this feature and I am of the opinion 
 > that a separate column is better. 

ok, lets call it "methods" and remove the unused "method" module
parameter.

 > And we should stick to the method IDs 
 > defined now in openser (see "enum request_method" in 
 > parser/msg_parser.h), they are bitmap flags and is easier to check them, 
 > and matches the result of parse_methods(). 

i know and agree.  i introduced the enum when i implemented parser
support for methods.

 > There is a special processing 
 > for unknown methods, we have to think of, e.g: in REGISTER the client 
 > advertise ASD method which will set METHOD_OTHER flag and if someone 
 > wants to send ZXC which also sets METHOD_OTHER, but is different than
 > ASD.

i think that if method is METHOD_OTHER, it should never match.

 > A limitation will come when the number of methods will exceeds 31, but I 
 > think there is enough space at this moment.

yes.

 > In the flags attribute should be kept the information whether to check 
 > the methods or not.

ok.

-- juha




More information about the Devel mailing list