[Devel] CVS commitlog: sip-server/parser parse_from.c

[Bogdan-Andrei Iancu]

Hi Klaus,

indeed, usually the FROM has a TAG param, but seams that not all SIP UA 
do so:; for example kphone doesn't append tag to REGISTER FROM hdr.

noting is broken - what I tried to do was to throw error in 
parse_from_header() function - it should be a nicer way to auto-detect 
broken messages; But I found clients which generates REGISTER without 
from tag :(, so I had to revert it.

so now it is as before.

maybe a short visit though the RFC will bring more light on this issue.

regards,
Bogdan

Klaus Darilion wrote:

> Bogdan-Andrei Iancu wrote:
>
>> User: bogdan_iancu
>> Date: 2005/07/12 12:45:15 PDT
>>
>>   OpenSER CVS - Commit Details
>>
>>   Modified files:
>>     parser               parse_from.c   Commit Log:
>>   REGISTER doesn't have a FROM TAG
>
>
> Really? Usually they have, e.g.: section 24.1 in rfc3261:
>        REGISTER sip:registrar.biloxi.com SIP/2.0
>        Via: SIP/2.0/UDP bobspc.biloxi.com:5060;branch=z9hG4bKnashds7
>        Max-Forwards: 70
>        To: Bob <sip:bob at biloxi.com>
>        From: Bob <sip:bob at biloxi.com>;tag=456248
>
> I hope this does not break things if the REGISTER contains a from tag.
>
> regards,
> klaus
>
>>     Revision  Changes    Path
>>   1.4       +3 -1      sip-server/parser/parse_from.c
>>    [ 
>> http://cvs.sourceforge.net/viewcvs.py/openser/sip-server/parser/parse_from.c?r1=1.3&r2=1.4 
>> ]
>>
>> _______________________________________________
>> Devel mailing list
>> Devel at openser.org
>> http://openser.org/cgi-bin/mailman/listinfo/devel
>>
>>
>
>