[Serdev] Re: [Devel] tm bug in t_hooks.c

[Federico Giannici]

Bogdan-Andrei Iancu wrote:
> Hi Cesc,
> 
> right!! as the transaction list is set all the time (disregarding the 
> presence of callbacks), it should be also unset all the time....

This solves the bug of the AVPs disappearing with retrasmitted INVITES 
too!!!

Bogdan, now you can remove that bug from the ones to search for...

Thank you Cesc.



> Cesc wrote:
> 
>> Hi,
>>
>> This bug haunted me for a lot of time (and ruined a couple of
>> demos)... and though used to fixing bugs, it is always deceiving how
>> many hours one can spend searching for ... just a misplaced bracket!!!
>> :)
>> Anyway, here it goes ...
>>
>> Regards,
>>
>> Cesc
>> PS - for any interested, this happened when using ser and sems via the
>> unix socket interface ... note that when the run_tm_callbacks function
>> was called, but no callback was found, the avp list would be left set
>> to that of the transaction .... and/or if more than one callback was
>> found, then the second callback would work on the global avp list, not
>> the transaction's ...
>> PS - This patch is for ser rel_0.9.0 ... but i guess the tm module did
>> not change much for following versions, not for ser, not for openser.
>>
>> ========================= START OF PATCH
>> --- t_hooks.c   2005-12-05 17:31:20.809656552 +0100
>> +++ ../../../branches/serMIRROR/modules/tm/t_hooks.c    2005-11-14
>> 11:46:52.000000000 +0100
>> @@ -189,8 +189,8 @@
>>                        params.param = &(cbp->param);
>>                        cbp->callback( trans, type, &params );
>>                }
>> -       }
>>        set_avp_list( backup );
>> +       }
>> }
>>
>> _______________________________________________
>> Devel mailing list
>> Devel at openser.org
>> http://openser.org/cgi-bin/mailman/listinfo/devel
>>
>>  
>>
> 
> _______________________________________________
> Serdev mailing list
> Serdev at iptel.org
> http://mail.iptel.org/mailman/listinfo/serdev
> 


-- 
___________________________________________________
     __
    |-                      giannici at neomedia.it
    |ederico Giannici      http://www.neomedia.it

         Presidente del cda - NEOMEDIA srl
___________________________________________________