Done.

The patch is in master and the 4.0 branch.

Thanks,

Peter


On 1 October 2013 08:22, Vitaliy Aleksandrov <vitalik.voip@gmail.com> wrote:
Hello,

Thank you for the explanation.
Could somebody review the patch in the attachment ? I tried to fix the problem with a growing tcpconn->refcnt for websocket connections.


On 30 September 2013 17:14, Vitaliy Aleksandrov <vitalik.voip@gmail.com> wrote:

Could you please share why nathelper aggregates both WS and WSS transports to "ws" and then msg_translator have to detect the type of a connection to a destination to build correct via ?

modules/nathelper/nathelper.c create_rcv_uri() function :
        case PROTO_WS:
        case PROTO_WSS:
                proto.s = "WS";
                proto.len = 2;
                break;


Because when the transport is WS (WebSockets over TCP) the URI has a transport parameter like this ";transport=ws" and when the transport is WSS (Secure WebSockets over TLS over TCP) the URI has a transport parameter like this ";transport=ws".  In other words, the transport parameter is the same for both and you need to make the determination within Kamailio core by checking how the specified socket is actually used.

--
Peter Dunkley
Technical Director
Crocodile RCS Ltd


_______________________________________________
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
sr-users@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users


_______________________________________________
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
sr-users@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users




--
Peter Dunkley
Technical Director
Crocodile RCS Ltd