_______________________________________________Hello,
to add a bit, because probably after this patch, I expect another linker issue will be reported -- the root issue is the fact that some newer linkers want inline functions to be declared static.
So more changes might be needed to add static to inline functions.
On the other hand, as I remember from some of code updates I made related to this issue, there are cases when inline functions had the prototype in header files, being defined in .c files and used in other c files. In such case, the solution is to remove the inline, because adding static is not going to work.
In short, for inline functions used only in a single file, add static, for inline functions used in many files, remove inline (both in .h and .c file).
Cheers,
Daniel
On 24.10.19 09:10, Henning Westerholt wrote:
Hello Brandon,
It is related to the linker, which has slightly a different behaviour nowadays. Therefore, it will not be fixed in the repository, 3.3 branch is long out of support.
Try this out:
diff --git a/raw_sock.c b/raw_sock.c
index b514a8784..1d18e5ab5 100644
--- a/raw_sock.c
+++ b/raw_sock.c
@@ -391,7 +391,7 @@ error:
* in _host_ order.
* @return the partial checksum in host order
*/
-inline unsigned short udpv4_vhdr_sum( struct udphdr* uh,
+static inline unsigned short udpv4_vhdr_sum( struct udphdr* uh,
struct in_addr* src,
struct in_addr* dst,
unsigned short length)
Cheers,
Henning
--
Henning Westerholt - https://skalatan.de/blog/
Kamailio services - https://skalatan.de/services
From: sr-users <sr-users-bounces@lists.kamailio.org> On Behalf Of Brandon Armstead
Sent: Thursday, October 24, 2019 7:11 AM
To: Kamailio (SER) - Users Mailing List <sr-users@lists.kamailio.org>
Subject: [SR-Users] Kamailio 3.3.7
Has anyone seen this error while compiling 3.3.7
raw_sock.c:431: undefined reference to `udpv4_vhdr_sum'
system:
Linux 4.9.0-11-amd64 #1 SMP Debian 4.9.189-3 (2019-09-02) x86_64 GNU/Linux
lsmod:
Module Size Used by
bonding 147456 0
intel_rapl 20480 0
x86_pkg_temp_thermal 16384 0
intel_powerclamp 16384 0
coretemp 16384 0
kvm_intel 200704 0
kvm 598016 1 kvm_intel
irqbypass 16384 1 kvm
ttm 98304 0
drm_kms_helper 155648 0
crct10dif_pclmul 16384 0
crc32_pclmul 16384 0
joydev 20480 0
evdev 24576 3
ghash_clmulni_intel 16384 0
drm 360448 2 ttm,drm_kms_helper
i2c_algo_bit 16384 0
iTCO_wdt 16384 0
shpchp 36864 0
ipmi_si 57344 0
iTCO_vendor_support 16384 1 iTCO_wdt
sg 32768 0
pcspkr 16384 0
mei_me 36864 0
ipmi_msghandler 49152 1 ipmi_si
mei 102400 1 mei_me
video 40960 0
button 16384 0
acpi_power_meter 20480 0
acpi_pad 24576 0
ib_iser 49152 0
rdma_cm 53248 1 ib_iser
iw_cm 49152 1 rdma_cm
ib_cm 45056 1 rdma_cm
ib_core 208896 4 ib_iser,ib_cm,rdma_cm,iw_cm
configfs 40960 2 rdma_cm
iscsi_tcp 20480 0
libiscsi_tcp 24576 1 iscsi_tcp
libiscsi 53248 3 ib_iser,libiscsi_tcp,iscsi_tcp
scsi_transport_iscsi 102400 4 ib_iser,libiscsi,iscsi_tcp
ip_tables 24576 0
x_tables 36864 1 ip_tables
autofs4 40960 2
ext4 589824 2
crc16 16384 1 ext4
jbd2 106496 1 ext4
crc32c_generic 16384 0
fscrypto 28672 1 ext4
ecb 16384 0
mbcache 16384 3 ext4
sd_mod 49152 4
hid_generic 16384 0
usbhid 53248 0
hid 122880 2 hid_generic,usbhid
crc32c_intel 24576 2
aesni_intel 167936 0
aes_x86_64 20480 1 aesni_intel
glue_helper 16384 1 aesni_intel
lrw 16384 1 aesni_intel
gf128mul 16384 1 lrw
ablk_helper 16384 1 aesni_intel
cryptd 24576 3 ablk_helper,ghash_clmulni_intel,aesni_intel
ahci 40960 3
xhci_pci 16384 0
libahci 32768 1 ahci
ixgbe 294912 0
xhci_hcd 188416 1 xhci_pci
i2c_i801 24576 0
i2c_smbus 16384 1 i2c_i801
dca 16384 1 ixgbe
ptp 20480 1 ixgbe
libata 249856 2 ahci,libahci
pps_core 16384 1 ptp
mdio 16384 1 ixgbe
usbcore 253952 3 usbhid,xhci_pci,xhci_hcd
scsi_mod 225280 7 ib_iser,sd_mod,libiscsi,libata,scsi_transport_iscsi,iscsi_tcp,sg
usb_common 16384 1 usbcore
fan 16384 0
thermal 20480 0
I believe I've crossed this issue once before and it was a simple apt-get package to include
compile options:
make include_modules="mi_fifo db_mysql tm dialog sl tmx kex rr maxfwd textops textopsx nathelper acc avpops xlog uac alias_db siputils utils usrloc registrar pv regex htable sqlops sdpops topoh ctl db_mysql mysql" prefix="/usr/local"
Thanks
- Brandon
_______________________________________________ Kamailio (SER) - Users Mailing List sr-users@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users-- Daniel-Constantin Mierla -- www.asipto.com www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio Advanced Training, Oct 21-23, 2019, Berlin, Germany -- https://asipto.com/u/kat
Kamailio (SER) - Users Mailing List
sr-users@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users