Hello,

On 7/6/12 1:36 AM, Andreas Granig wrote:
Hi,

The attached patch does the trick for me, but I'd rather like to have a
second opinion on it for any potential side effects before pushing it.

looks ok, go ahead and push it in master and then backport it.


The point here is that the fixup function didn't change (beside the
name) between 3.1 and 3.3, however 3.1 used dedicated w_replace_from1()
and w_replace_from2(), whereas 3.3 uses one unified w_replace_from(),
which breaks the behavior the fixup function is providing.

I see, thanks for clarifications.

Cheers,
Daniel

Thanks,
Andreas

On 07/05/2012 12:32 AM, Andreas Granig wrote:
Hi,

On 07/04/2012 09:42 PM, Daniel-Constantin Mierla wrote:
quick look into the sources shows that fixup makes the display parameter
null if its length is 0 -- perhaps introduced in the patch that unified
the fixup to work also for replacing the To header display. If you have
time and urgent need, you can push a fix for it asap, otherwise I will
look at it once getting some spare time out of traveling.
Ok, I'll have a look at it tomorrow and push a fix.

Andreas



_______________________________________________
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
sr-users@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users


      

_______________________________________________
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
sr-users@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users

-- 
Daniel-Constantin Mierla - http://www.asipto.com
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
Kamailio Advanced Training, Seattle, USA, Sep 23-26, 2012 - http://asipto.com/u/katu
Kamailio Practical Workshop, Netherlands, Sep 10-12, 2012 - http://asipto.com/u/kpw