Hello,

so I looked at the code and the patch was catching the case of no outgoing branches even for suspended transaction, to be coherent with the case when the transaction is not suspended. Practically there are two checks to detect these cases -- it is the code block at:

  * https://github.com/kamailio/kamailio/blob/master/src/modules/tm/t_fwd.c#L1276-L1295

Why would you need a failure_route execution in this case? Being a cancelled transaction by UAC, it should not be forwarded anymore.

I am trying to figure out if there is need to do a (rather complex) failure_route execution, or better introduce a (more lightweight) event_route for these cases (both with and without suspend).

Cheers,
Daniel

On 20.12.18 15:39, Daniel-Constantin Mierla wrote:
Hello,

Thanks for digging in further and providing the hints. I will look at it with the first chance. 

Cheers, 
Daniel 

On Thu, 20 Dec 2018, 13:39 Koray Vatansever <koray.vatansever@gmail.com wrote:
Hi Daniel,

After some debugging I realized that when the following commit removed, failure route is executed as expected:

Regards,
Koray

On Mon, Nov 12, 2018 at 11:15 AM Daniel-Constantin Mierla <miconda@gmail.com> wrote:

Hello,

I didn't get the chance to look at it so far. Also this week is very busy, but when I get a chance, I will check it.

Cheers,
Daniel


On 12.11.18 07:58, Koray Vatansever wrote:
Hi Daniel,

Did you have a chance to have a look at the logs that I provided to you?

If there is anything that I can do, just let me know.

Regards,
Koray



On Wed, Nov 7, 2018 at 3:29 PM Daniel-Constantin Mierla <miconda@gmail.com> wrote:
Hello,


On 07.11.18 06:46, Koray Vatansever wrote:
> Hi all,
>
> I'm trying to upgrade kamailio from 4.2.7 to 5.1.5 and I realized that
> when CANCEL is received for a suspended INVITE, failure route is not
> executed in release 5.1.5. 
> In 4.2.7 failure route is executed for this scenario.
>
> Is this the expected behaviour or am I missing something?
failure_route should be executed. Can you reproduce with debug=3 and
send all the logs related to this call, from receiving the INVITE till
the CANCEL is processed?

Cheers,
Daniel

--
Daniel-Constantin Mierla -- www.asipto.com
www.twitter.com/miconda -- www.linkedin.com/in/miconda
Kamailio World Conference -- www.kamailioworld.com
Kamailio Advanced Training, Nov 12-14, 2018, in Berlin -- www.asipto.com


-- 
Daniel-Constantin Mierla -- www.asipto.com
www.twitter.com/miconda -- www.linkedin.com/in/miconda
Kamailio World Conference -- www.kamailioworld.com
Kamailio Advanced Training, Nov 12-14, 2018, in Berlin -- www.asipto.com
-- 
Daniel-Constantin Mierla -- www.asipto.com
www.twitter.com/miconda -- www.linkedin.com/in/miconda
Kamailio World Conference - May 6-8, 2019 -- www.kamailioworld.com
Kamailio Advanced Training - Mar 4-6, 2019 in Berlin; Mar 25-27, 2019, in Washington, DC, USA -- www.asipto.com