From miconda@gmail.com Thu Aug 18 12:02:48 2022
From: Daniel-Constantin Mierla <miconda@gmail.com>
To: sr-users@lists.kamailio.org
Subject: Re: [SR-Users] How to enforce max_contacts at registration?
Date: Thu, 18 Aug 2022 12:02:41 +0200
Message-ID: <52f4c0c1-e802-e5de-9b67-47086a659e74@gmail.com>
In-Reply-To: <20220818100415.643b0daf@go.imp.ch>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1287620300=="

--===============1287620300==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello,

I looked at code and I couldn't spot quickly anything wrong with using
the xavp. I added more debug message in the git master branch.

Can you add:

pv_xavp_print();

just before save() in your config and test with git master branch and
debug=3D3? Then send the log messages printed for the registration that
should exceed the limit set in the xavp.

Cheers,
Daniel

On 18.08.22 10:04, Benoit Panizzon wrote:
> Hi Daniel
>
> debug=3D3
>
> Two CEP already registered. Registering a 3rd one (snom).
>
> Some IP and Hostnames replaced by 'HIDDEN'.
>
> Aug 18 07:52:55 dev-cpereg02 kamailio[1187007]: INFO: [1 315995001 zygwpey7=
(a)snom 1899942452 REGISTER]<script>: REGISTRAR: Setting max_contacts to 2 fo=
r sip:315995001(a)dev-cpereg02.HIDDEN
> Aug 18 07:52:55 dev-cpereg02 kamailio[1187007]: DEBUG: [1 315995001 zygwpey=
7(a)snom 1899942452 REGISTER]registrar [regpv.c:552]: pv_fetch_contacts_helpe=
r(): memory block between 0x7fd0c5bc7230 - 0x7fd0c5bc73a8
> Aug 18 07:52:55 dev-cpereg02 kamailio[1187007]: DEBUG: [1 315995001 zygwpey=
7(a)snom 1899942452 REGISTER]registrar [regpv.c:552]: pv_fetch_contacts_helpe=
r(): memory block between 0x7fd0c5bc7410 - 0x7fd0c5bc75ea
> Aug 18 07:52:55 dev-cpereg02 kamailio[1187007]: DEBUG: [1 315995001 zygwpey=
7(a)snom 1899942452 REGISTER]registrar [regpv.c:574]: pv_fetch_contacts_helpe=
r(): fetched <2> contacts for <315995001> in [caller]
> Aug 18 07:52:55 dev-cpereg02 kamailio[1187007]: INFO: [1 315995001 zygwpey7=
(a)snom 1899942452 REGISTER]<script>: REGISTRAR: Existing registration contac=
ts count: 2
> Aug 18 07:52:55 dev-cpereg02 kamailio[1187007]: INFO: [1 315995001 zygwpey7=
(a)snom 1899942452 REGISTER]<script>: REGISTRAR: 0: Contact-Address: sip:3159=
95001(a)HIDDEN:5060 Agent: Cisco/SPA112-1.4.1_SR5 Expires: 1660811132
> Aug 18 07:52:55 dev-cpereg02 kamailio[1187007]: INFO: [1 315995001 zygwpey7=
(a)snom 1899942452 REGISTER]<script>: REGISTRAR: 1: Contact-Address: sip:3159=
95001(a)HIDDEN;transport=3Dudp Agent: Linphone Desktop/ (Debian GNU/Linux 11 =
(bullseye), Qt 5.15.2) LinphoneCore/4.4.21 Expires: 1660810748
> Aug 18 07:52:55 dev-cpereg02 kamailio[1187007]: INFO: [1 315995001 zygwpey7=
(a)snom 1899942452 REGISTER]<script>: REGISTRAR: XAVP: <null> before setting
> Aug 18 07:52:55 dev-cpereg02 kamailio[1187007]: INFO: [1 315995001 zygwpey7=
(a)snom 1899942452 REGISTER]<script>: REGISTRAR: XAVP: 2 after setting
> Aug 18 07:52:55 dev-cpereg02 kamailio[1187007]: DEBUG: [1 315995001 zygwpey=
7(a)snom 1899942452 REGISTER]registrar [save.c:324]: pack_ci(): set instance[=
<urn:uuid:1844976b-42aa-4810-b846-13783b5a8c8f>]
> Aug 18 07:52:55 dev-cpereg02 kamailio[1187007]: DEBUG: [1 315995001 zygwpey=
7(a)snom 1899942452 REGISTER]<core> [core/utils/sruid.c:209]: sruid_nextx(): =
new sruid is [uloc-62fdee99-121cbf-1] (1 / 22)
> Aug 18 07:52:55 dev-cpereg02 kamailio[1187007]: DEBUG: [1 315995001 zygwpey=
7(a)snom 1899942452 REGISTER]registrar [save.c:420]: pack_ci(): generated rui=
d is: uloc-62fdee99-121cbf-1
> Aug 18 07:52:55 dev-cpereg02 kamailio[1187007]: DEBUG: [1 315995001 zygwpey=
7(a)snom 1899942452 REGISTER]registrar [save.c:607]: test_max_contacts(): 2 v=
alid contacts
> Aug 18 07:52:55 dev-cpereg02 kamailio[1187007]: DEBUG: [1 315995001 zygwpey=
7(a)snom 1899942452 REGISTER]registrar [save.c:629]: test_max_contacts(): 3 c=
ontacts after commit
>
> Produced by:
>
>         $avp(max_contacts) is 2 for this $aU.
>
> 	$var(saveuri) =3D "sip:" + $aU + "@" + $rd;
>
>         if ($avp(debug) > 0) {
>                 xlog("L_INFO", "$cfg(route): Setting max_contacts to $avp(m=
ax_contacts) for $var(saveuri)\n");
>                 if(reg_fetch_contacts("location", "$var(saveuri)", "caller"=
)) {
>                         xlog("L_INFO","$cfg(route): Existing registration c=
ontacts count: $(ulc(caller=3D>count))\n");
>                         $var(i) =3D 0;
>                         while($var(i) < $(ulc(caller=3D>count))) {
>                                 xlog("L_INFO","$cfg(route): $var(i): Contac=
t-Address: $(ulc(caller=3D>addr)[$var(i)]) Agent: $(ulc(caller=3D>user_agent)=
[$var(i)]) Expires: $(ulc(caller=3D>expires)[$var(i)])\n");
>                                 $var(i) =3D $var(i) + 1;
>                         }
>                 } else {
>                         xlog("L_INFO","$cfg(route): No existing contacts fo=
r AOR $var(saveuri)\n");
>                 }
>         }
>         xlog("L_INFO","$cfg(route): XAVP: $xavp(reg=3D>max_contacts) before=
 setting\n");
>         $xavp(reg=3D>max_contacts) =3D $avp(max_contacts);
>         xlog("L_INFO","$cfg(route): XAVP: $xavp(reg=3D>max_contacts) after =
setting\n");
>
> 	$var(result) =3D save("location","0x00","$var(saveuri)");
>
> =3D=3D snipp =3D=3D
>
> # kamctl ul show 315995001(a)dev-cpereg01.[HIDDEN] | grep Address
>           "Address":  "sip:315995001@[HIDDEN].229:5060",
>           "Address":  "sip:315995001@[HIDDEN]:9afa:9bff:fe4a:aa55];transpor=
t=3Dudp",
>           "Address":  "sip:315995001@[HIDDEN]:204:13ff:fe30:2a80]:3038;tran=
sport=3Dudp;line=3D8usewy",
>
> Mit freundlichen Gr=C3=BCssen
>
> -Beno=C3=AEt Panizzon-
> --=20
> I m p r o W a r e   A G    -    Leiter Commerce Kunden
> ______________________________________________________
>
> Zurlindenstrasse 29             Tel  +41 61 826 93 00
> CH-4133 Pratteln                Fax  +41 61 826 93 01
> Schweiz                         Web  http://www.imp.ch
> ______________________________________________________

--=20
Daniel-Constantin Mierla -- www.asipto.com
www.twitter.com/miconda -- www.linkedin.com/in/miconda



--===============1287620300==--