From miconda@gmail.com Tue Nov  1 17:35:13 2022
From: Daniel-Constantin Mierla <miconda@gmail.com>
To: sr-users@lists.kamailio.org
Subject: Re: [SR-Users] consume_credentials not working on PRACK?
Date: Tue, 01 Nov 2022 17:35:08 +0100
Message-ID: <74805267-e431-dead-414b-e9b932975d08@gmail.com>
In-Reply-To: =?utf-8?q?=3CAM6PR05MB54097C3C03FA977475C60AB0BF379=40AM6PR05MB?=
 =?utf-8?q?5409=2Eeurprd05=2Eprod=2Eoutlook=2Ecom=3E?=
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1490752023=="

--===============1490752023==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello,

likely the commit was done due to:

=C2=A0 - https://lists.kamailio.org/pipermail/sr-dev/2013-April/019470.html

However, apparently, even not common practice, PRACK can be challenged
for authentication.

Cheers,
Daniel

On 31.10.22 16:13, Henning Westerholt wrote:
> Hello,
>
> this was actually changed some years ago to be like this:
>
>
> commit 2a77ed2bdc9341ecf7d7200e420a1f49e4e9b6ab
> Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
> Date:   Sun Apr 14 10:11:29 2013 +0200
>
>     auth: skip processing of PRACK in consume_credentials()
>
> The issue probably was that the module logs an error if there are no creden=
tials in the message.
>
> This could be improved e.g. by a pull-request. For now you could just use t=
he remove_hf(..) function.
>
> Cheers,
>
> Henning
>
> --=20
> Henning Westerholt =E2=80=93 https://skalatan.de/blog/
> Kamailio services =E2=80=93 https://gilawa.com
>
> -----Original Message-----
> From: Benoit Panizzon <benoit.panizzon(a)imp.ch>=20
> Sent: Monday, October 31, 2022 3:50 PM
> To: Henning Westerholt <hw(a)gilawa.com>
> Cc: Kamailio (SER) - Users Mailing List <sr-users(a)lists.kamailio.org>
> Subject: Re: [SR-Users] consume_credentials not working on PRACK?
>
> Hi Henning
>
>> Maybe the PRACK is not a new request, but an in-dialog request and therefo=
re is not handled from the code quoted below.
> It is handled:
>
>                 if(!is_method("REGISTER|PUBLISH")) {
>                         consume_credentials();
>                         xlog("L_INFO", "$cfg(route): $rm creds: Mmmmmmh!\n"=
);
>                 }
>
> Log:
>
> [...] 3 PRACK]<script>: AUTH: Authentication successful!
> [...] 3 PRACK]<script>: AUTH: PRACK creds: Mmmmmmh!
>
> Mit freundlichen Gr=C3=BCssen
>
> -Beno=C3=AEt Panizzon-
> --=20
> I m p r o W a r e   A G    -    Leiter Commerce Kunden
> ______________________________________________________
>
> Zurlindenstrasse 29             Tel  +41 61 826 93 00
> CH-4133 Pratteln                Fax  +41 61 826 93 01
> Schweiz                         Web  http://www.imp.ch
> ______________________________________________________
> __________________________________________________________
> Kamailio - Users Mailing List - Non Commercial Discussions
> sr-users(a)lists.kamailio.org
> Important: keep the mailing list in the recipients, do not reply only to th=
e sender!
> Edit mailing list options or unsubscribe:
> https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users

--=20
Daniel-Constantin Mierla -- www.asipto.com
www.twitter.com/miconda -- www.linkedin.com/in/miconda
Kamailio Advanced Training - Online
  Nov 7-10, 2022 (Europe Timezone)
  * https://www.asipto.com/sw/kamailio-advanced-training-online/



--===============1490752023==--