[kamailio/kamailio] developing hiops module (#1856)
This is new module in Kamailio, named hiops module. I am developing and it take few time to done. In all over the module i used LM_INFO instead of LM_DBG, just for much easy troubleshooting. And also I would use lock for share memory in all project. These are some 'todo' project that i have to do. <!-- Kamailio Pull Request Template --> <!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception --> #### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description <!-- Describe your changes in detail --> You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1856 -- Commit Summary -- * add received_in_via function(use it in hiops module) * developing hiops module -- File Changes -- M src/core/msg_translator.c (25) M src/core/msg_translator.h (3) A src/modules/hiops (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1856.patch https://github.com/kamailio/kamailio/pull/1856.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1856
This is new module in Kamailio, named hiops module. I am developing and it take few time to done. In all over the module i used LM_INFO instead of LM_DBG, just for much easy troubleshooting. And also I would use lock for share memory in all project. These are some 'todo' project that i have to do. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1856#issuecomment-464347225
@mojtabaesfandiari pushed 1 commit. 065a102c1f53c5a43a77173a8688b6a13dcd44ab hiops module -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/kamailio/kamailio/pull/1856/files/af3f6d5962180e066b0ed93...
There is no code for your module, it seems you try to add it as a git submodule. It has to be pushed with full code, if you want it to merge it inside kamailio repository. Then your commit messages do not follow the contributing guidelines: * https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md#com... I also suggest that you put the function you added in core to your module, it seems to target usage only there and there is no reason it doesn't work having it inside your module. If it needs to be used in other modules later, it can be relocated. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1856#issuecomment-465522509
Hello, Yes, Tell me about it. I will do it as soon as. I am far away right now. Actually i am going to Germany embassy. On Wed, 20 Feb 2019, 14:15 Daniel-Constantin Mierla, < notifications@github.com> wrote:
There is no code for your module, it seems you try to add it as a git submodule. It has to be pushed with full code, if you want it to merge it inside kamailio repository.
Then your commit messages do not follow the contributing guidelines:
- https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md#com...
I also suggest that you put the function you added in core to your module, it seems to target usage only there and there is no reason it doesn't work having it inside your module. If it needs to be used in other modules later, it can be relocated.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <https://github.com/kamailio/kamailio/pull/1856#issuecomment-465522509>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ArE2rGb76fmIyAZqmVh6E3u57X8b4_nAks5vPScsgaJpZM4a-_NY> .
-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1856#issuecomment-465525720
I updated and now the codes is available for hiops module. In Regards of new function in core, I will do that. On Wed, Feb 20, 2019 at 2:15 PM Daniel-Constantin Mierla < notifications@github.com> wrote:
There is no code for your module, it seems you try to add it as a git submodule. It has to be pushed with full code, if you want it to merge it inside kamailio repository.
Then your commit messages do not follow the contributing guidelines:
- https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md#com...
I also suggest that you put the function you added in core to your module, it seems to target usage only there and there is no reason it doesn't work having it inside your module. If it needs to be used in other modules later, it can be relocated.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <https://github.com/kamailio/kamailio/pull/1856#issuecomment-465522509>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ArE2rGb76fmIyAZqmVh6E3u57X8b4_nAks5vPScsgaJpZM4a-_NY> .
-- --Mojtaba Esfandiari.S -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1856#issuecomment-465940688
@mojtabaesfandiari pushed 3 commits. 098e307e018e8866e3c7e09fb65c98850e82f3cf core: move the received_in_via function to hiops module bf31c7db4bfef15d89a24b663f9c05d68fe4a3e5 hiops: change function name 56ab9820cd957bb9af3aa7ebb7b79fdecc80a548 hiops: Add two function to these files -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/kamailio/kamailio/pull/1856/files/64f336d0ed2dca161beadf2...
@mojtabaesfandiari pushed 1 commit. c6e4844d3bf945ffd5f69c01a1b3dd12a161928e htable: add new function in htabe_api -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/kamailio/kamailio/pull/1856/files/56ab9820cd957bb9af3aa7e...
Thank you for the your interest in Kamailio and the module in development. I did a quick high level look today and have a few comments: - can you give a small description what your module actually does? :-) - a huge part of your code is related to the asn1 functionality. Some of this is library code that could be maybe placed elsewhere, some of them is generated from a ASN1 definition. If you finished the development we should discuss how to deal with this. Maybe something can be also just add as a build dependency and don't need to be included. - there is a cmake file inside, do you use cmake for something? In Kamailio we use standard make for building - you just pushed a change to the htable module, this should be a separate pull request as its isolated from your module -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1856#issuecomment-466956126
Hello Henning, In regards of first comment, This module is developed to provide handover interface for lawful Interception in IMS-Network(VoIP-Services) for Kamailio. Actually I am developing,yet, just as like some optimization code, add extra features and more. My implementation is based on ETSI TS133.108 and TS133.107. In this case Kamailio works just as LIG (Lawful Interception Gateway) in VoIP network and getting all data (signalling) from network and send them for LEA in specific (TLV) template. Along with of second comment, yes, of course. We could talk more about it after developing finished. As well as of third comment, i have never pushed cmake file before, It is my GUI (CLION GUI) for programming in C that i am working on with. And fourth comment, i deleted htable commit from here and make new pull request. With Best Regards. Mojtaba On Mon, Feb 25, 2019 at 1:49 PM Henning Westerholt <notifications@github.com> wrote:
Thank you for the your interest in Kamailio and the module in development. I did a quick high level look today and have a few comments:
- can you give a small description what your module actually does? :-) - a huge part of your code is related to the asn1 functionality. Some of this is library code that could be maybe placed elsewhere, some of them is generated from a ASN1 definition. If you finished the development we should discuss how to deal with this. Maybe something can be also just add as a build dependency and don't need to be included. - there is a cmake file inside, do you use cmake for something? In Kamailio we use standard make for building - you just pushed a change to the htable module, this should be a separate pull request as its isolated from your module
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <https://github.com/kamailio/kamailio/pull/1856#issuecomment-466956126>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ArE2rHQoyy1mbCV-B-ZItjank6pBnl0Rks5vQ7jLgaJpZM4a-_NY> .
-- --Mojtaba Esfandiari.S -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1856#issuecomment-466971511
Hello, thank you. About the remaining two topics: - regarding the ETSI standards, maybe you can add some comments later on how this module was tested against (like some hardware, vendor etc..) when you finished development - about the cmake file - if its only related to your local development environment, then please remove it from the pull request, it don't need to be integrated in the repository then Let us know when you've finished the implementation to follow up here. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1856#issuecomment-469011300
@mojtabaesfandiari pushed 1 commit. d3a762f56d2710c1e39c331f4ee8879921231264 hiops: remove cmake file from module -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/kamailio/kamailio/pull/1856/files/56ab9820cd957bb9af3aa7e...
Hello, Of course, Thank you On Sun, Mar 3, 2019 at 2:26 PM Henning Westerholt <notifications@github.com> wrote:
Hello, thank you. About the remaining two topics:
- regarding the ETSI standards, maybe you can add some comments later on how this module was tested against (like some hardware, vendor etc..) when you finished development - about the cmake file - if its only related to your local development environment, then please remove it from the pull request, it don't need to be integrated in the repository then Let us know when you've finished the implementation to follow up here.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <https://github.com/kamailio/kamailio/pull/1856#issuecomment-469011300>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ArE2rB5AdDNbEwiipla8tHmHIbJ5-5K4ks5vS6pGgaJpZM4a-_NY> .
-- --Mojtaba Esfandiari.S -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1856#issuecomment-469014247
No activity since beginning of March 2019, more than half a year. Is this still planned to be updated and merged? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1856#issuecomment-546319155
Hello, Yes, The delay is because of developing another module for Kamailio.called LREProxy. The process of developing LREProxy is done and the module is under stress test for checking it's performance. I am planning to update all codes of hoops module. Then uploa On Fri, Oct 25, 2019 at 3:06 PM Daniel-Constantin Mierla < notifications@github.com> wrote:
No activity since beginning of March 2019, more than half a year. Is this still planned to be updated and merged?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <https://github.com/kamailio/kamailio/pull/1856?email_source=notifications&email_token=AKYTNLBRKKY4QIMGFM4QPLTQQLK2NA5CNFSM4GX36NMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECICWMY#issuecomment-546319155>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKYTNLCNCGYEKLW422OJHD3QQLK2NANCNFSM4GX36NMA> .
-- --Mojtaba Esfandiari.S -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1856#issuecomment-546813073
Hello, Yes, The delay is because of developing another module for Kamailio.called LREProxy. The process of developing LREProxy is done and the module is under stress test for checking it's performance. I am planning to update all codes of hoops module. Then upload them. May be i could upload lreproxy sooner then hoops. On Fri, Oct 25, 2019 at 3:06 PM Daniel-Constantin Mierla < notifications@github.com> wrote:
No activity since beginning of March 2019, more than half a year. Is this still planned to be updated and merged?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <https://github.com/kamailio/kamailio/pull/1856?email_source=notifications&email_token=AKYTNLBRKKY4QIMGFM4QPLTQQLK2NA5CNFSM4GX36NMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECICWMY#issuecomment-546319155>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKYTNLCNCGYEKLW422OJHD3QQLK2NANCNFSM4GX36NMA> .
-- --Mojtaba Esfandiari.S -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1856#issuecomment-546814334
@mojtabaesfandiari pushed 0 commits. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/kamailio/kamailio/pull/1856/files/d3a762f56d2710c1e39c331...
Closed #1856. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1856#event-2985075779
why the hiops module pull request is closed after i update the base branch to master for new pull request? On Mon, Oct 28, 2019 at 10:19 AM Mojtaba <mespio@gmail.com> wrote:
Hello, Yes, The delay is because of developing another module for Kamailio.called LREProxy. The process of developing LREProxy is done and the module is under stress test for checking it's performance. I am planning to update all codes of hoops module. Then upload them. May be i could upload lreproxy sooner then hoops.
On Fri, Oct 25, 2019 at 3:06 PM Daniel-Constantin Mierla < notifications@github.com> wrote:
No activity since beginning of March 2019, more than half a year. Is this still planned to be updated and merged?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <https://github.com/kamailio/kamailio/pull/1856?email_source=notifications&email_token=AKYTNLBRKKY4QIMGFM4QPLTQQLK2NA5CNFSM4GX36NMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECICWMY#issuecomment-546319155>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKYTNLCNCGYEKLW422OJHD3QQLK2NANCNFSM4GX36NMA> .
-- --Mojtaba Esfandiari.S
-- --Mojtaba Esfandiari.S -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1856#issuecomment-579197572
Please looks at top of this page. You will find ``` kamailio:master from mojtabaesfandiari:master ``` This PR created using `master` branch in your fork repo. When you pushed a3dca98 commit as latest then GitHub can see that commit already exist in upstream repo and make decision no need PR more. To create PR more safe create dedicated branch with name related to feature. Like `mojtabaesfandiari:hiops`. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1856#issuecomment-579199970
Reopened #1856. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1856#event-2985330181
The progress will continue on hiops module #2209 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1856#issuecomment-579459228
Closed #1856. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1856#event-2987272298
participants (4)
-
Daniel-Constantin Mierla -
Henning Westerholt
-
mojtabaesfandiari
-
sergey-safarov