[kamailio/kamailio] core: print log_prefix after loglevel for more intuitive parsing (#1610)
<!-- Kamailio Pull Request Template --> <!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception --> #### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description <!-- Describe your changes in detail --> You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1610 -- Commit Summary -- * core: print log_prefix after loglevel for more intuitive parsing -- File Changes -- M src/core/dprint.h (16) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1610.patch https://github.com/kamailio/kamailio/pull/1610.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1610
This is a breaking change that would change the ordering of loglevel (e.g. INFO, WARN, NOTICE, etc) with the log_prefix parameter in the kamailio script. By having the loglevel precede the log_prefix, it is much easier to write logparsers that can easily ascertain what loglevel a message is before parsing the more application-specific behavior. Thoughts and comments welcome -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1610#issuecomment-409722882
I am fine with it, if nobody else has comments, I will merge it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1610#issuecomment-409736539
Thank you Armen for the patch. So the current way is: $log-prefix $log-level $log-message You change it to: $log-level $log-prefix $log-message I think the reasoning here was to easily distinguish Kamailio logs (with the prefix) from other application logs. But in the end this is better done with different log facilities anyway, and I think not that many people use a log prefix. So this change is also fine with me. But can you please put note about this in the upgrade wiki, as it will may break some people scripts: https://www.kamailio.org/wiki/install/upgrade/stable-to-devel -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1610#issuecomment-409831168
Merged #1610 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1610#event-1787132695
participants (3)
-
Armen Babikyan -
Daniel-Constantin Mierla
-
Henning Westerholt