Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
@henningw commented on this pull request.
In src/modules/ims_registrar_scscf/regpv.c:
> @@ -440,7 +451,15 @@ int pv_fetch_contacts(
return -1;
}
- ptr = 0; //r->contacts;TODO
+ rpp->impi.s = (char *)pkg_malloc(r->private_identity.len * sizeof(char));
+ if(rpp->impi.s == NULL) {
+ LM_ERR("no mem for impi\n");
+ return -1;
My expection would be that if a script function fails, there is no need to cleanup necessary in the kamailio cfg. So we should do a proper cleanup here and also in line 439. If you compare to the standard registrar module function, it also just uses the "goto error" logic.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.