Pre-Submission Checklist

• Commit message has the format required by CONTRIBUTING guide
• Commits are split per component (core, individual modules, libs, utils, ...)
• Each component has a single commit (if not, squash them into one commit)
• No commits to README files for modules (changes must be done to docbook files
  in doc/ subfolder, the README file is autogenerated)

Type Of Change

• Small bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds new functionality)
• Breaking change (fix or feature that would change existing functionality)

Checklist:

• PR should be backported to stable branches
• Tested changes locally
• Related to issue #XXXX (replace XXXX with an open issue number)

Description

The method dns_entry2he was returning 10 hostent structures, containing the same record, because the rr counter was never updated (10 being the value of DNS_HE_MAX_ADDR).

With this fix, the cache correctly returns all records found by the resolver.

In the documentation of dns_int_match_ip, it says:

At this moment, the function might not check all the IP addresses as returned by dns_sys_match_ip(), because the internal resolver targets to discover the first address to be used for relaying SIP traffic.

I believe that with this patch, dns_int_match_ip now also works for DNS entries with multiple values. I'm not sure about mixed ipv4/ipv6 though.

You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/2260

Commit Summary

• Fix returning multiple IP's for a cached DNS entry

File Changes

• M src/core/dns_cache.c (1)

Patch Links:

• https://github.com/kamailio/kamailio/pull/2260.patch
• https://github.com/kamailio/kamailio/pull/2260.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.