Pre-Submission Checklist

Commit message has the format required by CONTRIBUTING guide
Commits are split per component (core, individual modules, libs, utils, ...)
Each component has a single commit (if not, squash them into one commit)
No commits to README files for modules (changes must be done to docbook files
in doc/ subfolder, the README file is autogenerated)

Type Of Change

Small bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds new functionality)
Breaking change (fix or feature that would change existing functionality)

Checklist:

PR should be backported to stable branches
Tested changes locally
Related to issue #XXXX (replace XXXX with an open issue number)

Description

After enabling the Topos module, we ran into a bit of trouble with early in-dialog notifies. We use the event: talk package from Cisco Broadsoft to be able to do call control, as described in chapter 6 here: https://pubhub.devnetcloud.com/media/broadsoft-docs/docs/pdf/BW-SIPAccessSideExtensionsInterfaceSpec.pdf

This will send a NOTIFY with a header Event: talk before the first 200 OK. Currently this doesn't work with the topos module, since the NOTIFY method without a B-side contact will not check the INVITE record. When added to those methods in tps_msg.c, it tries to check the SUBSCRIBE for all NOTIFY's in tps_storage.c. The NOTIFY with Event: talk will follow on an INVITE, so there was a small change needed there.

I've limited it to just the NOTIFY's with the Event: talk header, to minimize any impact.

You can view, comment on, or merge this pull request online at:

https://github.com/kamailio/kamailio/pull/3627

Commit Summary

474aab1 topos: add compatiblity for early in-dialog NOTIFY

File Changes

(2 files)

M src/modules/topos/tps_msg.c (5)
M src/modules/topos/tps_storage.c (3)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.