Hello,<br>
Of course,<br>
Thank you<br>
<br>
On Sun, Mar 3, 2019 at 2:26 PM Henning Westerholt &lt;notifications@github.com&gt;<br>
wrote:<br>
<br>
&gt; Hello, thank you. About the remaining two topics:<br>
&gt;<br>
&gt;    - regarding the ETSI standards, maybe you can add some comments later<br>
&gt;    on how this module was tested against (like some hardware, vendor etc..)<br>
&gt;    when you finished development<br>
&gt;    - about the cmake file - if its only related to your local development<br>
&gt;    environment, then please remove it from the pull request, it don&#39;t need to<br>
&gt;    be integrated in the repository then<br>
&gt;    Let us know when you&#39;ve finished the implementation to follow up here.<br>
&gt;<br>
&gt; —<br>
&gt; You are receiving this because you are subscribed to this thread.<br>
&gt; Reply to this email directly, view it on GitHub<br>
&gt; &lt;https://github.com/kamailio/kamailio/pull/1856#issuecomment-469011300&gt;,<br>
&gt; or mute the thread<br>
&gt; &lt;https://github.com/notifications/unsubscribe-auth/ArE2rB5AdDNbEwiipla8tHmHIbJ5-5K4ks5vS6pGgaJpZM4a-_NY&gt;<br>
&gt; .<br>
&gt;<br>
<br>
<br>
-- <br>
--Mojtaba Esfandiari.S<br>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1856#issuecomment-469014247">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZaJTD3p3bhLplzncL1rIuF9uw7Ujks5vS7OJgaJpZM4a-_NY">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36ZTyFT5UVkOI7Ey_ES9GV4GKq0e5Tks5vS7OJgaJpZM4a-_NY.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@mojtabaesfandiari in #1856: Hello,\nOf course,\nThank you\n\nOn Sun, Mar 3, 2019 at 2:26 PM Henning Westerholt \u003cnotifications@github.com\u003e\nwrote:\n\n\u003e Hello, thank you. About the remaining two topics:\n\u003e\n\u003e    - regarding the ETSI standards, maybe you can add some comments later\n\u003e    on how this module was tested against (like some hardware, vendor etc..)\n\u003e    when you finished development\n\u003e    - about the cmake file - if its only related to your local development\n\u003e    environment, then please remove it from the pull request, it don't need to\n\u003e    be integrated in the repository then\n\u003e    Let us know when you've finished the implementation to follow up here.\n\u003e\n\u003e —\n\u003e You are receiving this because you are subscribed to this thread.\n\u003e Reply to this email directly, view it on GitHub\n\u003e \u003chttps://github.com/kamailio/kamailio/pull/1856#issuecomment-469011300\u003e,\n\u003e or mute the thread\n\u003e \u003chttps://github.com/notifications/unsubscribe-auth/ArE2rB5AdDNbEwiipla8tHmHIbJ5-5K4ks5vS6pGgaJpZM4a-_NY\u003e\n\u003e .\n\u003e\n\n\n-- \n--Mojtaba Esfandiari.S\n"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1856#issuecomment-469014247"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/1856#issuecomment-469014247",
"url": "https://github.com/kamailio/kamailio/pull/1856#issuecomment-469014247",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>