Hello,

since it is about 0|1 state, it can be probably stored as a bit over the dialog internal flags, which is iflags column.

Also, for the patch, do it without reformatting a lot of code, because it is not easy to track the real chances and review it. If there is lot to reformat, do a separate patch before or after the one that adds new features.

Cheers,
Daniel

On 06/01/14 13:31, Federico Cabiddu wrote:

Hi,

we are using the dialog module to limit the duration of users' calls.

We recently discovered (well, it's stated in the module doc) that each subsequent in-dialog request resets the dialog timeout. I can understand that this behavior can be useful in some cases, but in our is causing the call duration limitation to not work. I prepared a simple patch to introduce a new parameter to make this behavior configurable (per module). I would like to have it configurable per dialog, via means of an AVP,  but this would have implications on the dialog save/restore mechanism and on the db schema, so for the moment I left it simple.

Regards,

Federico Cabiddu

_______________________________________________
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

-- 
Daniel-Constantin Mierla - http://www.asipto.com
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda

_______________________________________________
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev