@rfuchs commented on this pull request.
A bit unsure about how this is supposed to work, maybe I'm just dense?
In src/modules/rtpengine/rtpengine.c:
> -static int fixup_set_id(void **param, int param_no) +static void rtpengine_dtmf_events_loop(int rank)
The rank
argument seems unused?
In src/modules/rtpengine/rtpengine.c:
> @@ -2147,6 +2401,9 @@ static int child_init(int rank) /* probe rtpengines only in first worker */ if(build_rtpp_socks(0, 1)) return -1; + + if (rtpengine_dtmf_event_sock.len > 0) + rtpengine_dtmf_events_loop(rank);
This enters into an infinite read loop during child_init(). Doesn't this block the startup of all child processes?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.