Hi Carsten,

Thanks. I looked into the 5.6 code, and its not there. So, its actually a regression fix for the previous commit 26ef622ff3621c8a82c1c3560a32e8d735e30c4e

Cheers,

Henning

--

Kamailio services - https://gilawa.com
Kamailio admin training April 2023: https://gilawa.com/en/services/admin-training

From: Carsten Bock <carsten@ng-voice.com>
Sent: Thursday, February 16, 2023 5:25 PM
To: Henning Westerholt <hw@gilawa.com>
Cc: Kamailio (SER) - Development Mailing List <sr-dev@lists.kamailio.org>
Subject: Re: [sr-dev] git:master:ac0edd34: dialog: Do not trigger bye_reply_cb for in-dialog requests

Hi,

this was actually triggered from the dlg_req_within() function, not from the dlg_bye() method. I use this to, for example, send in-dialog INFO/PRACK/UPDATE Messages, which should not cause the dialog to be terminated ;-)

Thanks,

Carsten

--

Carsten Bock I CTO & Founder

ng-voice GmbH

Trostbrücke 1 I 20457 Hamburg I Germany
T +49 179 2021244 I www.ng-voice.com

Registry Office at Local Court Hamburg, HRB 120189
Managing Directors: Dr. David Bachmann, Carsten Bock

Am Do., 16. Feb. 2023 um 17:18 Uhr schrieb Henning Westerholt <hw@gilawa.com>:

Hi Carsten,

I did not look into the code, but wondered why you do not want to execute a BYE callback for an (in-dialog) BYE?

Cheers,

Henning

--
Henning Westerholt - https://skalatan.de/blog/
Kamailio services - https://gilawa.com

-----Original Message-----
From: Carsten Bock <carsten@ng-voice.com>
Sent: Thursday, February 16, 2023 4:28 PM
To: sr-dev@lists.kamailio.org
Subject: [sr-dev] git:master:ac0edd34: dialog: Do not trigger bye_reply_cb for in-dialog requests

Module: kamailio
Branch: master
Commit: ac0edd34b491dc78bca6979d2f1444c50bfb7399
URL: https://github.com/kamailio/kamailio/commit/ac0edd34b491dc78bca6979d2f1444c50bfb7399

Author: Carsten Bock <carsten@ng-voice.com>
Committer: Carsten Bock <carsten@ng-voice.com>
Date: 2023-02-16T16:27:39+01:00

dialog: Do not trigger bye_reply_cb for in-dialog requests

---

Modified: src/modules/dialog/dlg_req_within.c

---

Diff:  https://github.com/kamailio/kamailio/commit/ac0edd34b491dc78bca6979d2f1444c50bfb7399.diff
Patch: https://github.com/kamailio/kamailio/commit/ac0edd34b491dc78bca6979d2f1444c50bfb7399.patch

---

diff --git a/src/modules/dialog/dlg_req_within.c b/src/modules/dialog/dlg_req_within.c
index 4f9ebfc693..a91bcec246 100644
--- a/src/modules/dialog/dlg_req_within.c
+++ b/src/modules/dialog/dlg_req_within.c
@@ -697,7 +697,7 @@ int dlg_request_within(struct sip_msg *msg, struct dlg_cell *dlg, int side,

        set_uac_req(&uac_r, method, allheaders.len?&allheaders:NULL,
                        (content && content->len)?content:NULL, dialog_info, TMCB_LOCAL_COMPLETED,
-                               bye_reply_cb, (void*)iuid);
+                               NULL, NULL);

        result = d_tmb.t_request_within(&uac_r);


_______________________________________________
Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-leave@lists.kamailio.org