Hi Carsten,

I did not look into the code, but wondered why you do not want to execute a BYE callback for an (in-dialog) BYE?

Cheers,

Henning

--
Henning Westerholt - https://skalatan.de/blog/
Kamailio services - https://gilawa.com

-----Original Message-----
From: Carsten Bock <carsten@ng-voice.com>
Sent: Thursday, February 16, 2023 4:28 PM
To: sr-dev@lists.kamailio.org
Subject: [sr-dev] git:master:ac0edd34: dialog: Do not trigger bye_reply_cb for in-dialog requests

Module: kamailio
Branch: master
Commit: ac0edd34b491dc78bca6979d2f1444c50bfb7399
URL: https://github.com/kamailio/kamailio/commit/ac0edd34b491dc78bca6979d2f1444c50bfb7399

Author: Carsten Bock <carsten@ng-voice.com>
Committer: Carsten Bock <carsten@ng-voice.com>
Date: 2023-02-16T16:27:39+01:00

dialog: Do not trigger bye_reply_cb for in-dialog requests

---

Modified: src/modules/dialog/dlg_req_within.c

---

Diff:  https://github.com/kamailio/kamailio/commit/ac0edd34b491dc78bca6979d2f1444c50bfb7399.diff
Patch: https://github.com/kamailio/kamailio/commit/ac0edd34b491dc78bca6979d2f1444c50bfb7399.patch

---

diff --git a/src/modules/dialog/dlg_req_within.c b/src/modules/dialog/dlg_req_within.c
index 4f9ebfc693..a91bcec246 100644
--- a/src/modules/dialog/dlg_req_within.c
+++ b/src/modules/dialog/dlg_req_within.c
@@ -697,7 +697,7 @@ int dlg_request_within(struct sip_msg *msg, struct dlg_cell *dlg, int side,

        set_uac_req(&uac_r, method, allheaders.len?&allheaders:NULL,
                        (content && content->len)?content:NULL, dialog_info, TMCB_LOCAL_COMPLETED,
-                               bye_reply_cb, (void*)iuid);
+                               NULL, NULL);

        result = d_tmb.t_request_within(&uac_r);


_______________________________________________
Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-leave@lists.kamailio.org