doc/
subfolder, the README file is autogenerated)The module has been broken in d00ceda. The code to replace strcpy() did not terminate the target sting with \0.
Discovered by our voiptests rig:
https://github.com/sippy/voiptests/actions/workflows/kamailio.yml
Results in a broken SDP (note garbage around o= attribute:
1681 00:00:08.271/GLOBAL/alice_ua: RECEIVED message from [::1]:5060:
1682 SIP/2.0 183 Session Progress
1683 Via: SIP/2.0/UDP [::1]:5061;received=::1;rport=5061;branch=z9hG4bK20a1169c6781e4bfe26554e84d3b4925
1684 Record-Route: <sip:[::1];ftag=l5v4RNY4iYqP.*!0LQUA.MLVq8RX'm!q;lr>
1685 From: "Alice Smith" <sip:alice_2_ipv6@[::1]>;tag=l5v4RNY4iYqP.*!0LQUA.MLVq8RX'm!q
1686 To: <sip:bob_2@[::1]>;tag=c77c4b2c8430cf6c18566bc3d9212ed3
1687 Call-ID: O%CciL!Yf0-SQn]G46v4J(SPddRr<MtH@)<0.ev}(]q.\%X[>
1688 CSeq: 200 INVITE
1689 Content-Type: application/sdp
1690 Content-Length: 296
1691
1692 v=0
1693 o=- 577651195072 577651195072 IN IP6 ::1\x86zU
1694 s=BOBSDP Session
1695 c=IN IP6 ::1\x86zU
1696 t=0 0
1697 m=image 13424 udptl t38
1698 a=T38FaxVersion:0
1699 a=T38MaxBitRate:14400
1700 a=T38FaxRateManagement:transferredTCF
1701 a=T38FaxMaxBuffer:262
1702 a=T38FaxMaxDatagram:176
1703 a=T38FaxUdpEC:t38UDPRedundancy
1704 a=nortpproxy:yes
1740 00:00:08.322/GLOBAL/alice_ua: RECEIVED message from 127.0.0.1:5060:
1741 SIP/2.0 183 Session Progress
1742 v: SIP/2.0/UDP 127.0.0.1:5061;received=127.0.0.1;rport=5061;branch=z9hG4bK8e357573055f35a768af0c9be78c836d
1743 Record-Route: <sip:127.0.0.1;ftag=q3~s'YH'`.Krs%LQKdFWrWnWgwPHJHnf;lr>
1744 f: "Alice Smith" <sip:alice_7_ipv4@127.0.0.1>;tag=q3~s'YH'`.Krs%LQKdFWrWnWgwPHJHnf
1745 t: <sip:bob_7@127.0.0.1>;tag=8ee80e5205ef358c3cb868fb5e5614f8
1746 i: m6!(QAFQlv}vTlycDH[rpMjW}mVV1phG@z/c{KI:L*n'[`%15
1747 CSeq: 200 INVITE
1748 c: application/sdp
1749 l: 328
1750
1751 v=0
1752 o=- 577651195078 577651195078 IN IP4 127.0.0.1z\xcfpzG\xd1\xcb`\xef=\x86zU
1753 s=BOBSDP Session
1754 c=IN IP4 127.0.0.1z\xcfpzG\xd1\xcb`\xef=\x86zU
1755 t=0 0
1756 m=image 13696 udptl t38
1757 a=T38FaxVersion:0
1758 a=T38MaxBitRate:14400
1759 a=T38FaxRateManagement:transferredTCF
1760 a=T38FaxMaxBuffer:262
1761 a=T38FaxMaxDatagram:176
1762 a=T38FaxUdpEC:t38UDPRedundancy
1763 a=nortpproxy:yes
Looks like there were multiple changes of the same nature. All of them probably needs to be re-evaluated to make sure this pattern is not propagated.
https://github.com/kamailio/kamailio/pull/3524
(1 file)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.