Pre-Submission Checklist

Commit message has the format required by CONTRIBUTING guide
Commits are split per component (core, individual modules, libs, utils, ...)
Each component has a single commit (if not, squash them into one commit)
No commits to README files for modules (changes must be done to docbook files
in doc/ subfolder, the README file is autogenerated)

Type Of Change

Small bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds new functionality)
Breaking change (fix or feature that would change existing functionality)

Checklist:

PR should be backported to stable branches
Tested changes locally
Related to issue #XXXX (replace XXXX with an open issue number)

Description

Currently stirshaken module performs x509 certificate path check twice (when enabled):

first by calling stir_shaken_verify_cert_path directly from the stirshaken_mod.c
second time from the libstirshaken

libstirshaken had the path check built in since approx 2020 (last commit mentioning it as TODO before the stir_shaken_verify_cert_path function was introduced). This shouldn't be an issue since stirshaken module was added to Kamailio in 2021.

This PR removes the x509 certificate path check from the stirshaken_mod.c by passing the responsibility to perform certificate path check to the libstirshaken.

You can view, comment on, or merge this pull request online at:

https://github.com/kamailio/kamailio/pull/4202

Commit Summary

1259c37 stirshaken: removed repeated x509 certification path check

File Changes

(2 files)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.