Pre-Submission Checklist

• Commit message has the format required by CONTRIBUTING guide
• Commits are split per component (core, individual modules, libs, utils, ...)
• Each component has a single commit (if not, squash them into one commit)
• No commits to README files for modules (changes must be done to docbook files
  in doc/ subfolder, the README file is autogenerated)

Type Of Change

• Small bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds new functionality)
• Breaking change (fix or feature that would change existing functionality)

Checklist:

• PR should be backported to stable branches
• Tested changes locally
• Related to issue #XXXX (replace XXXX with an open issue number)

Description

Hi there!
So my case, and why I did not use the existing code:

• incoming INVITE to a user with 2 records in usrloc (1st - UDP, 2nd - TLS)
• some time before lookup, TLS connect of 2nd device is closed, but usrloc record still exists (it going to be removed in the next iteration of timer)
• after lookup(location) - 2 branches are created
• send to 1st - UDP succeed
• send to 2nd - TLS failed. And here is my headache.
  -- I want to send push notification to this device
  -- I set t_on_branch_failure
  -- if I try failure_exec_mode=1 - I get control, and I am able to send push, but I need to wait until fr_timer fire (I wanted not to wait, and send immediately)

The idea of changes:

• usrloc -> get_urecord: if t_contact has tcpcon_id & connection is not alive => mark record as expired
• as a result, in the registrar, while lookup, this contact will fail VALID_CONTACT - and will not be returned to the scriptwriter.

All of this is wrapped by handle_lost_tcp parameter (that is 0 by default), so changes are extending of handle_lost_tcp parameter of usrloc. Checked doc for usrloc, and seems to me that current description of this parameter should be untouched.

Marked as expired contact will be removed by timer as usual.

Open for discussion, and thanks in advance.

You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/1365

Commit Summary

• pua_reginfo: use outbound proxy for PUBLISHes
• pua_reginfo: correct docs
• Merge branch 'master' of https://github.com/kamailio/kamailio
• usrloc: extend handle_lost_tcp use for get_urecord

File Changes

• M src/modules/usrloc/udomain.c (15)
• M src/modules/usrloc/urecord.c (4)
• M src/modules/usrloc/urecord.h (4)

Patch Links:

• https://github.com/kamailio/kamailio/pull/1365.patch
• https://github.com/kamailio/kamailio/pull/1365.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.