@lbalaceanu commented on this pull request.

I will continue the review tomorrow.

In src/modules/p_usrloc/p_usrloc_mod.c:

> @@ -307,6 +309,13 @@ static int mod_init(void)
 	}
 #endif
 
+	if((write_on_master_db_shared = shm_malloc(sizeof(dbm_write_t))) == NULL) {

Make sure to shm_free this allocated memory.

In src/modules/p_usrloc/p_usrloc_mod.h:

> @@ -123,5 +123,11 @@ extern int connection_expires;
 extern int alg_location;
 
 extern int  max_loc_nr;
+typedef struct dbm_write {

Structure name must be a noun.

In src/modules/p_usrloc/ul_db_watch.c:

> @@ -96,7 +96,10 @@ void check_dbs(unsigned int ticks, void *param){
 	ul_db_handle_list_t * tmp2, * new_element;
 	int found;
 	int i;
-	
+
+	if(mdb_availability_control) {

mdb_availability_control is also checked inside check_master_db() function.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.