@henningw commented on this pull request.


In src/modules/ims_registrar_scscf/regpv.c:

> @@ -423,7 +434,7 @@ int pv_fetch_contacts(
 	rpp->aor.s = (char *)pkg_malloc(aor.len * sizeof(char));
 	if(rpp->aor.s == NULL) {
 		LM_ERR("no more pkg\n");
-		return -1;
+		goto error;

Sorry to be annoying, but I would prefer to keep the -1 here, as we are not having any memory allocated yet, and to also stay in sync with the main registrar module implementation


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <kamailio/kamailio/pull/4166/review/2759394123@github.com>