There are already functions to parse a string to ip struct for ipv4 and ipv4, see str2ip() and str2ip6() in src/core/resolve.h . In that struct you have the af field. In most of the code, the two functions were used one after the other to parse ip addresses, if str2ip() fails, then try str2ip6().

We can add a new function str2ipx() as a wrapper to this logic, but otherwise, I see no reason to add the new functions proposed by your pull request.

Also, the one for trimming [ ] for ipv6 with copy over is not that useful in a global scope from my point of view. Moreover, there are no safety checks over the size of the target pointer, nor comments requesting a minimum value for that. This can be in the module that needs it.

I am closing this PR without merge. If people want to discuss more, then keep adding comments and if it is decided, it can be reopened.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.