commit cbcc27e broke RFC2543 hold

there's no need to check for sendrecv_mode, is_on_hold is either set or not in sdp_stream and/or sdp_session

Pre-Submission Checklist

• Commit message has the format required by CONTRIBUTING guide
• Commits are split per component (core, individual modules, libs, utils, ...)
• Each component has a single commit (if not, squash them into one commit)
• No commits to README files for modules (changes must be done to docbook files
  in doc/ subfolder, the README file is autogenerated)

Type Of Change

• Small bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds new functionality)
• Breaking change (fix or feature that would change existing functionality)

Checklist:

• PR should be backported to stable branches
• Tested changes locally
• Related to issue #XXXX (replace XXXX with an open issue number)

Description

removed the check for sendrecv_mode

You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/2844

Commit Summary

• textops: RFC2543 is broken

File Changes

• M src/modules/textops/textops.c (3)

Patch Links:

• https://github.com/kamailio/kamailio/pull/2844.patch
• https://github.com/kamailio/kamailio/pull/2844.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.