Hi Daniel,

thanks for pointing that out. In that case its only the pike top command without a lot of data.

But it makes indeed sense to have in similar for this particular use case.

Cheers,

Henning

From: Daniel-Constantin Mierla <notifications@github.com>
Sent: Mittwoch, 29. März 2023 14:42
To: Kamailio Devel List <sr-dev@lists.kamailio.org>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: [sr-dev] Re: [kamailio/kamailio] pike: use pkg_malloc/pkg_free instead of system malloc (6492a6f)

Probably this has to reverted, several rpc commands use system malloc on purpose if they might be returning a lot of data. Otherwise they will fail and allocating a lot of pkg at startup just for punctual needs of rpc commands is not recommended.

So, do not blindly replace system malloc/free with pkg variants if it is about rpc. jsonrpcs also uses system malloc, ctl as well, iirc ...

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <kamailio/kamailio/commit/6492a6f905075fa73d911c345fe784f2d3c085e5/106580236@github.com>