• nathelper sends ping only if nat flag is specified, but if ping_nated_only=0 it should ping all contact in any case.

Pre-Submission Checklist

• Commit message has the format required by CONTRIBUTING guide
• Commits are split per component (core, individual modules, libs, utils, ...)
• Each component has a single commit (if not, squash them into one commit)
• No commits to README files for modules (changes must be done to docbook files
  in doc/ subfolder, the README file is autogenerated)

Type Of Change

• Small bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds new functionality)
• Breaking change (fix or feature that would change existing functionality)

Checklist:

• PR should be backported to stable branches
• Tested changes locally
• Related to issue #XXXX (replace XXXX with an open issue number)

Description

We need to check presence of nat flag with check of ping_nated_only parameter to avoid situation when flag is not specified by user wants to ping all contacts and don't get any pings.

You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/1516

Commit Summary

• nathelper: it doesn't ping contacts if ping_nated_only=0

File Changes

• M src/modules/nathelper/nathelper.c (7)

Patch Links:

• https://github.com/kamailio/kamailio/pull/1516.patch
• https://github.com/kamailio/kamailio/pull/1516.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.