Hi Daniel,

thank you for your reply.

regarding mwi and dialoginfo, we are getting/creating the values that should be published inside the script. 

json module patch below

diff --git a/modules/json/json_mod.c b/modules/json/json_mod.c
index f102927..9fa0ec4 100644
--- a/modules/json/json_mod.c
+++ b/modules/json/json_mod.c
@@ -88,7 +88,7 @@
  }
 
  if (param_no == 3) {
- return fixup_free_pvar_null(param, 3);
+ return fixup_free_pvar_null(param, 1);
  }
 
  LM_ERR("invalid parameter number <%d>\n", param_no);





On Fri, Aug 22, 2014 at 2:37 PM, Daniel-Constantin Mierla <miconda@gmail.com> wrote:
Hello,

thanks for considering to contribute back to the public project.

Do you have the patches on some public server? If yes, send the link to them here, otherwise the best way is to upload them on our tracker:

- http://sip-router.org/tracker/

New features are included only on devel branch (git master branch). Due to 'stable' branch release policies, new features are not going to be included in 4.0 and 4.1. Next major release (4.2) is expected to be out by mid of October.

Regarding the new pua_mwi module, considering that kamailio is not tracking voicemail boxes, how is it getting the information?

And yes, that seems to be a bug in fixup_get_field_free() function, make a git patch for it, send here and I will push it.

Cheers,
Daniel


On 22/08/14 15:11, Luis Azedo wrote:
hi ,

i would like to submit a patch to pua_dialoginfo to expose the dialog_publish function to the script so that we can configure something like this in the script.

route[MY_ROUTE]
{
   pua_dialoginfo_publish(.......)
}

i also want to provide a new module pua_mwi that publishes mwi info.

what's the proper flow to submit this ? i want to submit it to 4.0 and 4.1 branch.


also, there seems to be a bug in json module on fixup_get_field_free function
if (param_no == 3) {
return fixup_free_pvar_null(param, 3); <<<== shouldn't this be 1 ?
}


thanks



_______________________________________________
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

-- 
Daniel-Constantin Mierla
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
Next Kamailio Advanced Trainings 2014 - http://www.asipto.com
Sep 22-25, Berlin, Germany ::: Oct 15-17, San Francisco, USA